Skip to content

Make "Open in Terminal" button accessible #4631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −3
Open

Make "Open in Terminal" button accessible #4631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f6fca6
label dropdown with terminal button
ashton22305 Sep 25, 2025
54b6531
Internationalize Open in Terminal
ashton22305 Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions apps/dashboard/app/views/files/_shell_dropdown.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,14 @@
render(partial: 'shared/shell_button',
locals: {
path: @path,
label: 'Open in Terminal',
label: I18n.t('dashboard.files_shell'),
classes: 'btn btn-outline-dark btn-sm',
icon: 'fas fa-terminal'
icon: 'fas fa-terminal',
id: 'files-shell-button'
})
%>
<% if Configuration.login_clusters.count > 0 %>
<button type="button" class="btn btn-sm btn-outline-dark dropdown-toggle dropdown-toggle-split" data-bs-toggle="dropdown" aria-haspopup="true" aria-expanded="false"></button>
<button type="button" class="btn btn-sm btn-outline-dark dropdown-toggle dropdown-toggle-split" data-bs-toggle="dropdown" aria-haspopup="true" aria-expanded="false" aria-label="<%= I18n.t('dashboard.files_shell_dropdown') %>"></button>
<ul class="dropdown-menu" data-popper-placement="right-start" id="shell-dropdown-items">
<% Configuration.login_clusters.each do |cluster| %>
<li>
Expand Down
2 changes: 2 additions & 0 deletions apps/dashboard/config/locales/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,8 @@ en:
files_remote_disabled: Remote file support is not enabled
files_remote_empty_dir_unsupported: Remote does not support empty directories
files_remote_error_listing_remotes: 'Error listing Rclone remotes: %{error}'
files_shell: Open in Terminal
files_shell_dropdown: Select Cluster to Open in Terminal
import: Import
jobs_create_blank_project: Create a new project
jobs_create_template_project: Create a new project from a template
Expand Down