-
Notifications
You must be signed in to change notification settings - Fork 1
os2web_key #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
os2web_key #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5368531
to
e88cbe5
Compare
jekuaitk
approved these changes
May 16, 2024
51bd586
to
2ca5bd7
Compare
# Conflicts: # src/Plugin/os2web/DataLookup/DataLookupBase.php # src/Plugin/os2web/DataLookup/DatafordelerBase.php # src/Plugin/os2web/DataLookup/DatafordelerCVR.php # src/Plugin/os2web/DataLookup/DatafordelerPNumber.php # src/Plugin/os2web/DataLookup/ServiceplatformenBase.php # src/Plugin/os2web/DataLookup/ServiceplatformenCPR.php # src/Plugin/os2web/DataLookup/ServiceplatformenCPRExtended.php
# Conflicts: # CHANGELOG.md
2ca5bd7
to
d28b14f
Compare
stankut
reviewed
Jun 17, 2025
stankut
approved these changes
Jun 18, 2025
@rimi-itk looks good to me! |
i suggest to go for the major version if possible. we are using this package in other projects as well. Would be nice to differenciate. |
We'll go for a major release – better safe than sorry. And a major release signals that care must be taken when upgrading (eventhough nothing has to be done). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
composer.json
(using https://github.com/ergebnis/composer-normalize)