Skip to content

Conversation

rimi-itk
Copy link
Contributor

@rimi-itk rimi-itk commented May 1, 2024

@rimi-itk rimi-itk marked this pull request as ready for review May 1, 2024 15:12
@rimi-itk rimi-itk marked this pull request as draft May 1, 2024 15:13
@rimi-itk rimi-itk force-pushed the feature/os2web_key branch 2 times, most recently from 5368531 to e88cbe5 Compare May 1, 2024 15:27
@rimi-itk rimi-itk marked this pull request as ready for review May 13, 2024 11:30
@rimi-itk rimi-itk requested a review from jekuaitk May 15, 2024 07:45
@rimi-itk rimi-itk force-pushed the feature/os2web_key branch 2 times, most recently from 51bd586 to 2ca5bd7 Compare December 20, 2024 14:09
rimi-itk added 7 commits May 2, 2025 14:27
# Conflicts:
#	src/Plugin/os2web/DataLookup/DataLookupBase.php
#	src/Plugin/os2web/DataLookup/DatafordelerBase.php
#	src/Plugin/os2web/DataLookup/DatafordelerCVR.php
#	src/Plugin/os2web/DataLookup/DatafordelerPNumber.php
#	src/Plugin/os2web/DataLookup/ServiceplatformenBase.php
#	src/Plugin/os2web/DataLookup/ServiceplatformenCPR.php
#	src/Plugin/os2web/DataLookup/ServiceplatformenCPRExtended.php
# Conflicts:
#	CHANGELOG.md
@rimi-itk rimi-itk force-pushed the feature/os2web_key branch from 2ca5bd7 to d28b14f Compare May 2, 2025 12:29
@rimi-itk rimi-itk changed the base branch from 8.x to main May 2, 2025 12:29
@rimi-itk rimi-itk requested review from stankut and jekuaitk June 17, 2025 20:47
@stankut
Copy link
Contributor

stankut commented Jun 18, 2025

@rimi-itk looks good to me!

@rimi-itk
Copy link
Contributor Author

@stankut @jekuaitk, when merging this, should we go for a major (i.e. 3.0.0) or a minor release (2.1.0)? We won't break anything (hopefully).

@jekuaitk
Copy link
Contributor

@stankut @jekuaitk, when merging this, should we go for a major (i.e. 3.0.0) or a minor release (2.1.0)? We won't break anything (hopefully).

As everything should be backwards compatible i vote 2.1.0.

@stankut
Copy link
Contributor

stankut commented Jun 18, 2025

i suggest to go for the major version if possible.

we are using this package in other projects as well. Would be nice to differenciate.

@rimi-itk
Copy link
Contributor Author

We'll go for a major release – better safe than sorry. And a major release signals that care must be taken when upgrading (eventhough nothing has to be done).

@rimi-itk rimi-itk merged commit 7e35a12 into OS2web:main Jun 18, 2025
4 checks passed
@rimi-itk rimi-itk deleted the feature/os2web_key branch June 18, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants