Revert accidental commits #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blattms
referenced
this pull request
Aug 3, 2018
This is mandated by the DUNE interface. It also makes a lot of sense because now people do not need to think whether const auto& center = entity.geometry().center(); might cause a dangling reference. It just wont as it is always a copy and never a reference to a member.
|
Thanks. I'll merge this right away to restore the original state. Then I absolutely support getting to the point where we honour the requirements of the Dune interface. |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just in case that these break something. They should have gone into PR #334 and fix the issues that are
still there. But somehow I messed up completely (including the branch of the PR).