Throw for complex std::pow results in CO2::vaporPressure #4514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
jenkins build this please |
Member
|
The safeguard added here is fine. I will add a fix that make sure it never is thrown. I suggest we merge that fix first. |
Member
|
jenkins build this please |
totto82
reviewed
Mar 14, 2025
| Evaluation exponent = 0; | ||
| Evaluation critTemp = criticalTemperature(); | ||
| Evaluation Tred = T/criticalTemperature(); | ||
|
|
Member
There was a problem hiding this comment.
Maybe use critTemp here since you just copied it.
totto82
reviewed
Mar 14, 2025
| // this is on page 1524 of the reference | ||
| Evaluation exponent = 0; | ||
| Evaluation critTemp = criticalTemperature(); | ||
| Evaluation Tred = T/criticalTemperature(); |
totto82
reviewed
Mar 14, 2025
| for (int i = 0; i < 4; ++i) | ||
| exponent += a[i]*pow(1 - Tred, t[i]); | ||
| exponent += a[i]*pow(1 - T/critTemp, t[i]); | ||
| exponent *= 1.0/Tred; |
Member
|
This can be merged when the small nitpicks have been fixed. |
Member
Author
|
It seems to me that the solution actually goes to zero when we approach zero from the positive side. Maybe we should just use 0 values <=0? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::pow may throw for negative base and non-integer exponent, g++ doesn't. Here we add an explicit throw.