dpdk: add initial unittests for DPDK codebase v10 #13971
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 6, 2025 18:22
To better control the values within the variables and to prepare for the follow-up unit tests, the variable was moved into global scope and should accessed only by functions. This allows reinstantination of the variable value - needed for unit tests. Ticket: 6927
Needed by unit tests to properly reset the device list. Ticket: 6927
For the upcoming changes, skipping a unit test might be beneficial when testing a function that retrieves hardware data. This can e.g. depend on the number of CPU cores and systems that does not meet the required test criteria will need to omit the tests. The tests should always target minimal system requirements Ticket: 6927
The commit adds unit tests for mempool cache calculation. The DPDK mempool cache can be automatically calculated from the size of the mempool. The commit also adds unit tests for automatic thread distribution when multiple interfaces are present and when there is a possible overlap with management threads. Ticket: 6927
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #13971 +/- ##
==========================================
+ Coverage 83.87% 83.89% +0.02%
==========================================
Files 1011 1011
Lines 275561 275850 +289
==========================================
+ Hits 231128 231434 +306
+ Misses 44433 44416 -17
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Information: QA ran without warnings. Pipeline = 27884 |
|
In what environment would I see tests skipped? |
|
In this case, it would be in environments with not enough CPUs to try some of the CPU affinity functions. |
|
Follow-up in #14113 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #13957
Link to ticket: https://redmine.openinfosecfoundation.org/issues/6927
The PR is adding unit tests tailored to verify CPU threading logic and the automatic calculation of mempool cache of the interface.
Describe changes:
v2:
v1: