Detect integers multi 7480 v4.1 #13872
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to be able to use it outside of ldap Ticket: 7480 No behavior change, just code restyling
Ticket: 7480 No behavior change, just code restyling
And make ldap use them Ticket: 7480 No behavior change, just code restyling
And make ldap use it Ticket: 7480 No behavior change, just code restyling
as we do not pop Ticket: 7480 May have a behavior change, but only in terms of performance
and make ldap use it Ticket: 7480 No behavior change, just code restyling
Ticket: 7480
Ticket: 7480 Describing the usage of index
Ticket: 7480
Ticket: 7480
Ticket: 7480
As is done for absent keyword for instance
For example dns.rrtype: !A,nb>3 will match if we have more than 3 dns records which are not A
To match if array is empty, or index is out of bounds
catenacyber
requested review from
jasonish,
jufajardini and
victorjulien
as code owners
|
Replaced by #13873 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/7480
Describe changes:
SV_BRANCH=OISF/suricata-verify#2653
#13838 with better history, more SV tests, fixes...
@victorjulien should I do a first PR with commits up to
rust/detect: generic detect_uint_match_at_index?More TODOs:
countfeature in relation to detect: count keywords for multi-buffer #13783 and Victor wanting a new keywordvlan.layersinstead of a count option tovlan.idList of keywords to do :
./src/suricata --list-keywords=csv | grep uint | grep multi | cut -d\; -f1