Safely handle missing active viewport #5448
Open
+5
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Sometimes, when switching hanging protocols, the
activeViewport
can be undefined.This caused errors because the code assumed that an active viewport would always be present.
Changes & Results
Added a guard clause in
_syncWithActiveViewport
to safely handle case where:activeViewport
is undefined.viewport
exists.Before:
Changing hanging protocols could throw errors when no active viewport was set.
Before:
The app now gracefully skips syncing when there is no active viewport.
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment