feat(MeasurementService): add rendering of unmapped measurements #5416
Conversation
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Viewers
|
||||||||||||||||||||||||||||
| Project |
Viewers
|
| Branch Review |
feat/display-unmapped-measurements
|
| Run status |
|
| Run duration | 02m 36s |
| Commit |
|
| Committer | Bill Wallace |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
37
|
| View all changes introduced in this branch ↗︎ | |
igoroctaviano
changed the title
|
@sedghi this PR is the follow up on our desperate attempts to fix point/contour SR annotation rendering for the past 5 years. Appreciate your support to get this merged. |
platform/ui-next/src/components/MeasurementTable/MeasurementTable.tsx
Outdated
Show resolved
Hide resolved
platform/core/src/services/MeasurementService/MeasurementService.ts
Outdated
Show resolved
Hide resolved
platform/core/src/services/MeasurementService/MeasurementService.ts
Outdated
Show resolved
Hide resolved
extensions/cornerstone-dicom-sr/src/getSopClassHandlerModule.ts
Outdated
Show resolved
Hide resolved
extensions/cornerstone-dicom-sr/src/getSopClassHandlerModule.ts
Outdated
Show resolved
Hide resolved
platform/ui-next/src/components/MeasurementTable/MeasurementTable.tsx
Outdated
Show resolved
Hide resolved
|
@jbocce can you check/help Igor why tests are failing? then we merge |
It looks like only one test is failing: 
I will let you decide whether this is expected or not. 😊 |
@jbocce, thx for pointing it out. The screenshot should look like this? hard to read |
@igoroctaviano , that is the diff of the expected versus actual. Here is the expected... 
And this is the actual (i.e. with your changes in this PR)... 
|
| } | ||
|
|
||
| export const DataRow: React.FC<DataRowProps> = ({ | ||
| const DataRowComponent: React.FC<DataRowProps> = ({ |
There was a problem hiding this comment.
Please export it - having this sort of thing exported allows for re-use.
There was a problem hiding this comment.
@igoroctaviano can you address this one last comment?
There was a problem hiding this comment.
It's being exported as you can see at the bottom:
const DataRow = DataRowComponent as React.FC<DataRowProps> & {
Status: typeof Status;
};
DataRow.Status = Status;
export default DataRow;
export { DataRow };
|
@fedorov Thanks for your team's contribution. Just a friendly reminder that we need to add tests for these so that it does not get broken again |
|
@sedghi thank you! I completely agree. Issue created, and we will address this. |
|
@fedorov Do you have such data at IDC? |
|
Unfortunately, there are still issues:
@deepakri201 will add details to #5081 / #5082. |
I added a screenshot to this issue with the bounding boxes rendered and displayed in the right panel. Please share the dataset you are using. |
Context
This PR addresses the issue where DICOM SR (Structured Report) measurements that cannot be mapped to existing measurement tools were not being displayed in the measurement panels. Previously, unmapped measurements were silently ignored, making them invisible to users even though the data existed in the DICOM SR.
The changes ensure that all measurements from DICOM SR files are visible to users, with clear visual indicators when measurements cannot be properly mapped to standard measurement tools.
Changes & Results
Changes Made:
getSopClassHandlerModule.tsto use proper TypeScript types and consistent formattinguseMeasurementsto include unmapped measurements in the displayResults:
Testing
To test these changes:
Load a DICOM SR file with measurements that don't map to standard tools:
Verify unmapped measurements are displayed:
Test measurement interactions:
Check JSDoc improvements:
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment