[16.0][FIX] base_report_to_printer: do not download text report sent to printer #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-delbovier-acsone
changed the title
nicolas-delbovier-acsone
force-pushed
the
16.0-fix-base_report_to_printer-dont-download-text-report-sent-to-printer-nde
branch
2 times, most recently
from
1fdec0d to
be89501
Compare
…nter In the case of a report of type "qweb-text" set to "Send to printer" (e.g. a zpl report), the pervious implementation was triggering a download of the report. This is because inside the base odoo report handling function (odoo/addons/web/static/src/webclient/actions/action_service.js -> `_executeReportAction`), the code defaults to 'download' for text reports that have not been dealt with and current implementation only deals with "qweb-pdf" reports. However, the supported types defined inside `REPORT_TYPES` are ["qweb-pdf", "qweb-text"]. Thus, the current approach now creates a new computed field `is_report_to_printer_action` (to replace the previous hard-coded solution) to deal with the logic of ensuring the report is of the expected type before triggering our custom action handler.
nicolas-delbovier-acsone
force-pushed
the
16.0-fix-base_report_to_printer-dont-download-text-report-sent-to-printer-nde
branch
from
be89501 to
cc915c3
Compare
lmignon
approved these changes
Aug 29, 2025
lmignon
approved these changes
Aug 29, 2025
rousseldenis
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of a report of type "qweb-text" set to "Send to printer" (e.g. a zpl report), the pervious implementation was triggering a download of the report.
This is because inside the base odoo report handling function (odoo/addons/web/static/src/webclient/actions/action_service.js ->
_executeReportAction), the code defaults to 'download' for text reports that have not been dealt with and current implementation only deals with "qweb-pdf" reports.However, the supported types defined inside
REPORT_TYPESare ["qweb-pdf", "qweb-text"].Thus, the current approach now creates a new computed field
is_report_to_printer_action(to replace the previous hard-coded solution) to deal with the logic of ensuring the report is of the expected type before triggering our custom action handler.