[16.0][FIX] purchase_deposit: fixes account.tax access error in a multi company environment #2867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ti company environment Solves access error when creating a Deposit invoice, because it was getting all the product taxes of the existing companies.
ljsalvatierra-factorlibre
approved these changes
Nov 3, 2025
dreispt
reviewed
Nov 8, 2025
| self.deposit_account_id = product.property_account_expense_id | ||
| self.deposit_taxes_id = product.supplier_taxes_id | ||
| self.deposit_taxes_id = product.supplier_taxes_id.filtered( | ||
| lambda tx: tx.company_id == self.env.company |
Member
There was a problem hiding this comment.
Shouldn't we honor the document's company?
Suggested change
| lambda tx: tx.company_id == self.env.company | |
| lambda tx: tx.company_id == self.company_id |
Member
Author
There was a problem hiding this comment.
in this case "self" is the wizard, not the document, and the wizard has no company field. This method
depends on purchase_deposit_product_id field, and where the purchase_deposit_product_id field is defined, it uses the env company
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves access error when creating a Deposit invoice, because it was getting all the product taxes of the existing companies.
