Fixes #27737: Add the possibility to get all inventory where lastInventoryDate is after a given datetime #6658
+354
−125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR updated with a new commit |
…ntoryDate is after a given datetime
|
PR rebased |
clarktsiory
force-pushed
the
enh_27737/add_the_possibility_to_get_all_inventory_where_lastinventorydate_is_after_a_given_datetime
branch
from
de60f8f to
f26e99d
Compare
…astInventoryDate is after a given datetime Fixes #27737: Add the possibility to get all inventory where lastInventoryDate is after a given datetime
|
PR updated with a new commit |
…where lastInventoryDate is after a given datetime Fixes #27737: Add the possibility to get all inventory where lastInventoryDate is after a given datetime
|
PR updated with a new commit |
…entory where lastInventoryDate is after a given datetime Fixes #27737: Add the possibility to get all inventory where lastInventoryDate is after a given datetime
|
PR updated with a new commit |
fanf
reviewed
Oct 23, 2025
...ources/rudder/rudder-core/src/main/scala/com/normation/rudder/domain/queries/CmdbQuery.scala
Outdated
Show resolved
Hide resolved
fanf
reviewed
Oct 23, 2025
| case (false, LesserEq) => LTEQ(attributeName, dateString) | ||
| // case Regex => HAS(attributeName) //"default, non interpreted regex | ||
| case _ => HAS(attributeName) // default to Exists | ||
| case _ => HAS(attributeName) // default to Exists |
There was a problem hiding this comment.
Something feels strange, because IIRC, the inventory date is in CoreNodeFact, so it's the memory checker that is used, not the old LDAP one for that part. But you didn't seem to have changed NodeCriterionMatcherDate or other matcher.
Perhaps I'm just not remember correctly how things work.
There was a problem hiding this comment.
indeed, it's addressed in 287f7d7
And I left this code there, since it's an enhancement that applies to any "date" fields (I mentioned them in the PR description)
…all inventory where lastInventoryDate is after a given datetime Fixes #27737: Add the possibility to get all inventory where lastInventoryDate is after a given datetime
|
PR updated with a new commit |
fanf
reviewed
Oct 29, 2025
...r/rudder-core/src/main/scala/com/normation/rudder/domain/queries/NodeQueryCriteriaData.scala
Show resolved
Hide resolved
clarktsiory
commented
Oct 30, 2025
...ources/rudder/rudder-core/src/main/scala/com/normation/rudder/domain/queries/CmdbQuery.scala
Outdated
Show resolved
Hide resolved
...r/rudder-core/src/main/scala/com/normation/rudder/domain/queries/NodeQueryCriteriaData.scala
Show resolved
Hide resolved
…to get all inventory where lastInventoryDate is after a given datetime Fixes #27737: Add the possibility to get all inventory where lastInventoryDate is after a given datetime
|
PR updated with a new commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/27737
Allow to parse a "date" (
yyyy-MM-dd) and a "datetime" (ISO8601 format, without the milliseconds i.e.yyyy-MM-ddTHH:mm:ssZ) at the same time in a date comparator :Z(it could be edited by hand though)Screenshot :
It also extends the format of the following fields (there is still backward compatibility for dates) :
Note : it's still using our default joda-time parser, without the support of millis. Later we could imagine using explicit Java time formatters (as in the unit tests), which support both
TODO: add clear examples in the API doc of the datetime formats