Skip to content

Conversation

@annlew
Copy link
Contributor

@annlew annlew commented Aug 13, 2024

Summary: Test for checking functionality of --usr_mech_infile option for CAM_CONFIG_OPTS

Contributors: @annlew

Reviewers: @gold2718

Purpose of changes: Test to catch chemistry preprocessor failure

Github PR URL:

Changes made to build system: None

Changes made to the namelist: None

Changes to the defaults for the boundary datasets: None

Substantial timing or memory changes: None

Issues addressed by this PR:
cam_chempp issue with usr_mech_infile when path to compiler is too long (NorESMhub/CAM#160)

addresses NorESMhub/CAM#160

@annlew annlew marked this pull request as ready for review August 13, 2024 14:03
@TomasTorsvik TomasTorsvik requested a review from gold2718 August 19, 2024 12:34
@TomasTorsvik
Copy link
Contributor

Duplicates PR #545 , but for noresm2_1_develop branch.
Presumably, we want to include this in the noresm2.1.2 release?

@gold2718
Copy link

Duplicates PR #545 , but for noresm2_1_develop branch. Presumably, we want to include this in the noresm2.1.2 release?

Yes.

@TomasTorsvik
Copy link
Contributor

@gold2718 - do you have a chance to look at this PR? I'm a bit concerned about the line

rm -f $CIMEROOT/../components/cam/chem_proc/campp

but on the other hand, the suggested mychems testmods is not part of the default testlist_allactive.xml. If I understand correctly, the mychems testmods will only be activated if the testlist_allactive.xml is changed, hence this PR should not change the default behavior?

@TomasTorsvik TomasTorsvik self-requested a review September 10, 2024 22:12
Copy link
Contributor

@TomasTorsvik TomasTorsvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this PR only provides an optional setting for regression testing, I will approve it now. If a better solution is found, we can change this again later.

@TomasTorsvik TomasTorsvik self-assigned this Sep 10, 2024
@TomasTorsvik TomasTorsvik merged commit 5d43e64 into NorESMhub:noresm2_1_develop Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants