refactor co2 fossil fue and aircraft emissions to leverage CDEPS online functionality #244

mvertens · 2025-11-04T14:39:42Z

Summary: Enable fossil fuel and aircraft co2 forcing that are currently on a 2 degree FV grid to be remapped online to the model grid and time interpolated to the model time using CDEPS in-line functionality. The grid mapping is currently hard-wired to be bilinear, but I am incorporating a new namelist to also easily enable first-order conservative.

Still to do:

Test restarts
Make mapping type a namelist variable

@adagj @DirkOlivie @tjiputra - the following lists how you can get and use the new code (still in testing)

to get the current branch:

> git clone https://github.com/mvertens/NorESM noresm3_0_beta03b_co2refactor
> cd noresm3_0_beta03b_co2refactor
> git checkout feature/refactor_co2input 
> ./bin/git-fleximod update

compset and resolution

--compset 1850_CAM70%LT%NORESM%CAMoslo_CLM60%FATES_CICE_BLOM%HYB%ECO_MOSART_DGLC%NOEVOLVE_SWAV_SESP_BGC%BPRP
-res ne16pg3_tn14

user_nl_cam

the key additions are co2flux_fuel_mesh, co2_flux_fuel_year_first, co2_flux_fuel_year_last, co2_flux_fuel_year_align
to understand these definitions in more detail see
https://escomp.github.io/CDEPS/versions/master/html/index.html
https://escomp.github.io/CDEPS/versions/master/html/streams.html#data-model-stream-inline-api (this is the functionality used in co2_cycle.F90 and co2_data_flux.F90)

interpolate_nlat           = 96
interpolate_nlon           = 144
interpolate_output         = .true.
use_aerocom                = .false.
history_aerosol            = .false.
zmconv_c0_lnd              =  0.0075D0
zmconv_c0_ocn              =  0.0300D0
zmconv_ke                  =  5.0E-6
zmconv_ke_lnd              =  1.0E-5
clim_modal_aero_top_press  =  1.D-4
bndtvg                     = '/cluster/shared/noresm/inputdata/atm/cam/ggas/noaamisc.r8.nc'
dust_emis_method           = 'Leung_2023'
dust_emis_fact             = 6.1D0
rafsip_on                  = .true.
micro_mg_dcs               = 700.D-6
clubb_c8                   =  5.3
clubb_l_do_expldiff_rtm_thlm = .true.
co2_flag                = .true.
co2_readflux_aircraft   = .true.
co2_readflux_fuel       = .true.
aircraft_co2_datafile   = '/cluster/shared/noresm/inputdata/atm/cam/ggas/emissions-cmip6_CO2_anthro_ac_ScenarioMIP_IAMC-REMIND-MAGPIE-ssp534_201401-210112_fv_1.9x2.5_c20220809.nc'
aircraft_co2_fldname    = 'ac_CO2'
aircraft_co2_meshfile   = '/cluster/shared/noresm/inputdata/share/meshes/fv1.9x2.5_141008_ESMFmesh_c20191001.nc'
aircraft_co2_year_first = 2014
aircraft_co2_year_last  = 2101
aircraft_co2_year_align = 2014
aircraft_co2_taxmode    = 'limit'
!co2flux_fuel_datafile  = '/cluster/shared/noresm/inputdata/atm/cam/ggas/emissions-cmip6_CO2_anthro_surface_ScenarioMIP_IAMC-REMIND-MAGPIE-ssp534_201401-210112_fv_1.9x2.5_c20220809.nc'
co2flux_fuel_datafile   = '/cluster/projects/nn9560k/adagj/co2files/emissions-cmip6_CO2_anthro_surface_2xScenarioMIP_IAMC-REMIND-MAGPIE-ssp534_201401-210112_fv_1.9x2.5_c20220809.nc'
co2flux_fuel_meshfile   = '/cluster/shared/noresm/inputdata/share/meshes/fv1.9x2.5_141008_ESMFmesh_c20191001.nc'
co2flux_fuel_year_first = 2014
co2flux_fuel_year_last  = 2101
co2flux_fuel_year_align = 2014
co2flux_fuel_taxmode    = 'limit'

Reviewers: @gold2718

Changes made to build system: None

Changes made to the namelist: [ describe or write 'None' ]

Changes to the defaults for the boundary datasets: [ describe or write 'None' ]

Substantial timing or memory changes: [ describe or write 'None' ]

Validation:

The left plot is the model output on day 16 (2 degree forcing mapped to ne16 and then mapped back out to 2 degree history output)
The right plot is the forcing dataset /cluster/shared/noresm/inputdata/atm/cam/ggas/emissions-cmip6_CO2_anthro_surface_ScenarioMIP_IAMC-REMIND-MAGPIE-ssp534_201401-210112_fv_1.9x2.5_c20220809.nc on January 16

tjiputra · 2025-11-04T16:04:32Z

@mvertens, this command doesn't work
./bin/git-fleximod update

mvertens · 2025-11-04T16:38:09Z

@mvertens, this command doesn't work ./bin/git-fleximod update

@tjiputra - sorry about that - my checkout missed that you need to invoke
> git checkout feature/refactor_co2input
I've updated the documentation.

adagj · 2025-11-05T08:59:19Z

@mvertens Thank you Mariana! I will run a N1850 compset with 2xSSP534 CO2 flux data to see if we can track down the (potential) CO2 conservation issue in CAM

gold2718

I still have most of co2_cycle.F90 and nudging.F90 to review but here are some items I think should be changed.

bld/namelist_files/namelist_definition.xml

gold2718 · 2025-11-25T16:45:11Z

src/cpl/nuopc/atm_shr.F90

+  public
+
+  type(ESMF_Mesh)  :: model_mesh     ! model mesh
+  type(ESMF_Clock) :: model_clock    ! model clock


I think this should be private with protected variables initialized by a subroutine:

Suggested change

public

type(ESMF_Mesh) :: model_mesh ! model mesh

type(ESMF_Clock) :: model_clock ! model clock

private

type(ESMF_Mesh), public, protected :: model_mesh ! model mesh

type(ESMF_Clock), public, protected :: model_clock ! model clock

public :: initialize_model_clock

public :: initialize_model_mesh

logical :: model_clock_initialized = .false.

logical :: model_mesh_initialized = .false.

contains

subroutine initialize_model_clock(mclock)

use shr_sys_mod, only: shr_sys_abort

type(ESMF_Clock), intent(in) :: mclock

if (model_clock_initialized) then

call shr_sys_abort('initialize_model_clock: model clock already initialized')

else

model_clock = mclock

model_clock_initialized = .true.

end if

end subroutine initialize_model_clock

subroutine initialize_model_mesh(mmesh)

use shr_sys_mod, only: shr_sys_abort

type(ESMF_Mesh), intent(in) :: mmesh

if (model_mesh_initialized) then

call shr_sys_abort('initialize_model_mesh: model mesh already initialized')

else

model_mesh = mmesh

model_mesh_initialized = .true.

end if

end subroutine initialize_model_mesh

gold2718 · 2025-11-25T16:47:17Z

src/cpl/nuopc/atm_comp_nuopc.F90

+       ! Create model_clock as a variable in atm_shr.F90 - needed for generating streams
+       model_clock = ESMF_ClockCreate(clock, rc=rc)
+       if (ChkErr(rc,__LINE__,u_FILE_u)) return


I think some or all of this should move into atm_shr.F90

gold2718 · 2025-11-25T20:14:10Z

src/physics/cam/co2_cycle.F90

+   character(len=cs)  :: co2flux_ocn_tintalgo = 'linear'  ! time interpolation [lower, upper, nearest, linear or coszen]
+   character(len=cs)  :: co2flux_ocn_taxmode = 'extend'   ! time extraploation [cycle, extend or limit]


I think that these should also be initialized to invalid values. This would have caught the missing namelist variables.

Suggested change

character(len=cs) :: co2flux_ocn_tintalgo = 'linear' ! time interpolation [lower, upper, nearest, linear or coszen]

character(len=cs) :: co2flux_ocn_taxmode = 'extend' ! time extraploation [cycle, extend or limit]

character(len=cs) :: co2flux_ocn_tintalgo = 'NOTSET' ! time interpolation [lower, upper, nearest, linear or coszen]

character(len=cs) :: co2flux_ocn_taxmode = 'NOTSET' ! time extraploation [cycle, extend or limit]

gold2718 · 2025-11-25T20:14:43Z

src/physics/cam/co2_cycle.F90

+   character(len=cs)  :: co2flux_fuel_tintalgo = 'linear' ! time interpolation [lower, upper, nearest, linear or coszen]
+   character(len=cs)  :: co2flux_fuel_taxmode = 'extend'  ! time extraploation [cycle, extend or limit]


I think that these should also be initialized to invalid values. This would have caught the missing namelist variables.

Suggested change

character(len=cs) :: co2flux_fuel_tintalgo = 'linear' ! time interpolation [lower, upper, nearest, linear or coszen]

character(len=cs) :: co2flux_fuel_taxmode = 'extend' ! time extraploation [cycle, extend or limit]

character(len=cs) :: co2flux_fuel_tintalgo = 'NOTSET' ! time interpolation [lower, upper, nearest, linear or coszen]

character(len=cs) :: co2flux_fuel_taxmode = 'NOTSET' ! time extraploation [cycle, extend or limit]

…r.F90 for model_mesh and model_clock

…ised in the PR review

mvertens · 2025-12-01T09:20:56Z

@gold2718 - I have removed nudging capability as part of this PR. I have also removed co2_readFlux_ocn from CAM as part of this PR. I think all of the comments above that refer to either of these changes are addressed as part of this removal.

mvertens · 2025-12-01T09:21:16Z

@gold2718 - what tests do you want me to run?

…O2 from file

mvertens · 2025-12-03T21:54:24Z

@gold2718 - I think this is now ready for another review.

mvertens marked this pull request as draft November 4, 2025 14:39

gold2718 self-requested a review November 14, 2025 13:42

gold2718 self-assigned this Nov 14, 2025

gold2718 added the enhancement New feature or request label Nov 14, 2025

gold2718 added this to NorESM Development Nov 14, 2025

github-project-automation bot moved this to Todo in NorESM Development Nov 14, 2025

gold2718 added this to the NorESM3.0 milestone Nov 14, 2025

gold2718 requested changes Nov 25, 2025

View reviewed changes

github-project-automation bot moved this from Todo to In Progress in NorESM Development Nov 25, 2025

mvertens marked this pull request as ready for review November 25, 2025 21:09

mvertens and others added 11 commits November 26, 2025 09:57

first pass at refactoring the nudging code

f3cc48c

fixed compiler issues

601ecd3

more refactor of code

99b98fa

migrated atm_stream_nuding.F90 code into nudging.F90 and added atm_sh…

e48da5b

…r.F90 for model_mesh and model_clock

fixes to nudging for running

d9b8012

refactor of co2_cycle and co2_data_flux to use cdeps streams

46c9114

first pass at the validation

1f3d7d9

addressed issues in the PR

8a8c1fb

more updates

3c642b5

added aircraft emissions to this PR and also addressed more issues ra…

2fc0734

…ised in the PR review

fixed compilation problem

089444c

mvertens force-pushed the feature/refactor_co2input branch from 5d1d8c5 to 089444c Compare November 26, 2025 09:12

mvertens requested a review from gold2718 November 26, 2025 09:14

mvertens changed the title ~~refactor co2input to have online interpolation for fossil fuel and ocn datasets~~ refactor co2_cycle and co2 aircraft emissions to have CDEPS online functionality Nov 26, 2025

mvertens added 2 commits November 27, 2025 09:43

updates for default namelists

ebd61ba

removed co2_readFlux_ocn

42f8e97

mvertens changed the title ~~refactor co2_cycle and co2 aircraft emissions to have CDEPS online functionality~~ refactor co2 fossil fue and aircraft emissions to leverage CDEPS online functionality Dec 1, 2025

mvertens added 2 commits December 3, 2025 12:56

updates for namelist in aircraft_emit.F90 and removal of ocean read C…

d4323c9

…O2 from file

cleanup of co2_data_flux.F90

ad01c91

-  public
-  type(ESMF_Mesh)  :: model_mesh     ! model mesh
-  type(ESMF_Clock) :: model_clock    ! model clock
+  private
+  type(ESMF_Mesh), public, protected  :: model_mesh     ! model mesh
+  type(ESMF_Clock), public, protected :: model_clock    ! model clock
+  public :: initialize_model_clock
+  public :: initialize_model_mesh
+  logical :: model_clock_initialized = .false.
+  logical :: model_mesh_initialized = .false.
+contains
+  subroutine initialize_model_clock(mclock)
+    use shr_sys_mod, only: shr_sys_abort
+    type(ESMF_Clock), intent(in) :: mclock
+    if (model_clock_initialized) then
+      call shr_sys_abort('initialize_model_clock: model clock already initialized')
+    else
+      model_clock = mclock
+      model_clock_initialized = .true.
+    end if
+  end subroutine initialize_model_clock
+  subroutine initialize_model_mesh(mmesh)
+    use shr_sys_mod, only: shr_sys_abort
+    type(ESMF_Mesh), intent(in) :: mmesh
+    if (model_mesh_initialized) then
+      call shr_sys_abort('initialize_model_mesh: model mesh already initialized')
+    else
+      model_mesh = mmesh
+      model_mesh_initialized = .true.
+    end if
+  end subroutine initialize_model_mesh

		character(len=cs) :: co2flux_ocn_tintalgo = 'linear' ! time interpolation [lower, upper, nearest, linear or coszen]
		character(len=cs) :: co2flux_ocn_taxmode = 'extend' ! time extraploation [cycle, extend or limit]

		character(len=cs) :: co2flux_fuel_tintalgo = 'linear' ! time interpolation [lower, upper, nearest, linear or coszen]
		character(len=cs) :: co2flux_fuel_taxmode = 'extend' ! time extraploation [cycle, extend or limit]

refactor co2 fossil fue and aircraft emissions to leverage CDEPS online functionality #244

Are you sure you want to change the base?

refactor co2 fossil fue and aircraft emissions to leverage CDEPS online functionality #244

Uh oh!

Conversation

mvertens commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tjiputra commented Nov 4, 2025

Uh oh!

mvertens commented Nov 4, 2025

Uh oh!

adagj commented Nov 5, 2025

Uh oh!

gold2718 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mvertens commented Dec 1, 2025

Uh oh!

mvertens commented Dec 1, 2025

Uh oh!

mvertens commented Dec 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mvertens commented Nov 4, 2025 •

edited

Loading