forked from ESCOMP/CAM
-
Notifications
You must be signed in to change notification settings - Fork 24
CAM computes enthalpy to send to BLOM #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mvertens
wants to merge
84
commits into
NorESMhub:noresm_develop
Choose a base branch
from
mvertens:feature/cam_computes_enthalpy
base: noresm_develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CAM computes enthalpy to send to BLOM #240
mvertens
wants to merge
84
commits into
NorESMhub:noresm_develop
from
mvertens:feature/cam_computes_enthalpy
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uritzen (NCAR) and Thomas Toniazzo (Bjerknes Centre / NORCE) and option for ZM changes programmed by Thomas Toniazzo
Adjust test length for FATES-nocomp compatibility Contributors: @gold2718 Reviewers: @mvdebolskiy Purpose of changes: FAIL in aux_cam_noresm test: ERP_Ln9.ne16pg3_ne16pg3_mtn14.NF1850ghg_fates-nocomp.betzy_intel.cam-outfrq9s (NorESMhub/NorESM#695) Github PR URL: NorESMhub#236 Changes made to build system: None Changes made to the namelist: None Changes to the defaults for the boundary datasets: None Substantial timing or memory changes: None Because FATES-nocomp can only restart on daily boundaries, this test needed to be converted into a multi-day test instead of a multi-timestep test. Testing: - Ran `ERP_Ld5.ne16pg3_ne16pg3_mtn14.NF1850ghg_fates-nocomp.betzy_intel.cam-outfrq9s` to ensure the new test length passes. - Test has an `NLCOMP` failure due to ESCOMP#235 and a `BFAIL` because this test did not `PASS` in Beta02. - Ran `aux_cam_noresm`: Same result as in ESCOMP#235 except that the test above now passes restart compare.
…variable from mediator now
…iagnostics.F90 and added a new namelist variable history_enthalpy_flux
…or_phys/physics/check_energy.F90 and src/physics/camnor_phys/physics/check_energy_chng.F90
…ulting in errors in DEBUG mode and they actually don't do anything at this point
…BUG mode and did participate in any computation
fixed problem if refactor - this will change answers
Update PUMAS tag with RAFSiP bug fix Summary: Update PUMAS tag with secondary ice bug fix Contributors: @oyvindseland, @gold2718 Reviewers: @oyvindseland Purpose of changes: Salinity drift in NorESM; NorESMhub/NorESM#718 Github PR URL: NorESMhub#239 Changes made to build system: None Changes made to the namelist: None Changes to the defaults for the boundary datasets: None Substantial timing or memory changes: None Updated PUMAS tag
This was referenced Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
CAM computes enthalpy fluxes to send to BLOM. Created by Peter Lauritzen (NCAR) and Thomas Toniazzo (Bjerknes Centre / NORCE)
Also depends on submodule PRs:
Also depends on other component PRs:
Contributors: Thomas Tonazzio, @oyvindseland @gold2718
Purpose of changes: [ Include the issue number and title text for each relevant GitHub issue ]
This PR supersedes #227
Tested:
TODO: Also summarize fully coupled tests