Skip to content

Conversation

@mvertens
Copy link

@mvertens mvertens commented Oct 9, 2025

Summary:
CAM computes enthalpy fluxes to send to BLOM. Created by Peter Lauritzen (NCAR) and Thomas Toniazzo (Bjerknes Centre / NORCE)

Also depends on submodule PRs:

Also depends on other component PRs:

Contributors: Thomas Tonazzio, @oyvindseland @gold2718

Purpose of changes: [ Include the issue number and title text for each relevant GitHub issue ]
This PR supersedes #227

Tested:

  • Sandbox: noresm3_0_beta03a with new branches corresponding to above PRs
  • Ran aux_cam_noresm and compared to noresm3_0_beta03a - all tests passed
  • AMIP runs with enthalpy enable MUST have the CMEPS PR above - otherwise this PR can be accepted without any of the other depend PRs accepted
    TODO: Also summarize fully coupled tests

Øyvind Seland and others added 30 commits June 14, 2025 19:18
…uritzen (NCAR) and Thomas Toniazzo (Bjerknes Centre / NORCE) and option for ZM changes programmed by Thomas Toniazzo
Adjust test length for FATES-nocomp compatibility

Contributors: @gold2718
Reviewers: @mvdebolskiy

Purpose of changes: FAIL in
    aux_cam_noresm test: ERP_Ln9.ne16pg3_ne16pg3_mtn14.NF1850ghg_fates-nocomp.betzy_intel.cam-outfrq9s
   (NorESMhub/NorESM#695)

Github PR URL: NorESMhub#236
Changes made to build system: None
Changes made to the namelist: None
Changes to the defaults for the boundary datasets: None
Substantial timing or memory changes: None

Because FATES-nocomp can only  restart on daily boundaries, this test
needed to be converted into a multi-day test instead of a multi-timestep test.

Testing:
- Ran
  `ERP_Ld5.ne16pg3_ne16pg3_mtn14.NF1850ghg_fates-nocomp.betzy_intel.cam-outfrq9s`
  to ensure the new test length passes.
    - Test has an `NLCOMP` failure due to ESCOMP#235 and a `BFAIL` because this
      test did not `PASS` in Beta02.
- Ran `aux_cam_noresm`: Same result as in ESCOMP#235 except that the test above
  now passes restart compare.
…iagnostics.F90 and added a new namelist variable history_enthalpy_flux
…or_phys/physics/check_energy.F90 and src/physics/camnor_phys/physics/check_energy_chng.F90
…ulting in errors in DEBUG mode and they actually don't do anything at this point
…BUG mode and did participate in any computation
@mvertens mvertens requested a review from gold2718 October 9, 2025 08:05
@mvertens mvertens marked this pull request as draft October 9, 2025 08:05
@mvertens mvertens changed the title Feature/cam computes enthalpy CAM computes enthalpy to send to BLOM Oct 9, 2025
@mvertens mvertens marked this pull request as ready for review October 10, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant