feat: add domain templates feature #42
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toledosteve
commented
Oct 16, 2023
toledosteve
commented
- Add support for domain templates as defined in the MG API here: https://documentation.mailgun.com/en/latest/api-templates.html#templates
toledosteve
force-pushed
the
feature/domain-templates
branch
from
c17e065 to
66cc7df
Compare
mrchrishahn
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Please merge this PR. Code is clean and naming simply follows the mailgun.js naming.
I could understand if the methods provided from this PR may better be exposed under a nested property, like domains to not pollute the main namespace. But that is a super minor detail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.