server: fix registration edge case check when the address is already registered #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…registered
this is an edge case - if the wallet is already registered and say the node
is moved to some other machine or if the repo is deleted and started all over again
then there wouldn't be any file at ../node-lite/register-tx-hash.txt because contracts/lite-register.js
would return from `if (await checkIfRegistered(signerAddress))` condition and would not write anything
to txHashPath in `fs.writeFileSync(txHashPath, tx.hash);`. So now the server code checks if the
signer address is already registered and thus prevents the error caused in `node-lite/register.js`'s
`Step:5 console.log(orange.bold('\n🔶 Step 5: Server Registration'))`.
Signed-off-by: 0xnightwind <[email protected]>
|
@NetrumLabs ? @ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is an edge case - if the wallet is already registered and say the node is moved to some other machine or if the repo is deleted and started all over again then there wouldn't be any file at ../node-lite/register-tx-hash.txt because contracts/lite-register.js would return from
if (await checkIfRegistered(signerAddress))condition and would not write anything to txHashPath infs.writeFileSync(txHashPath, tx.hash);. So now the server code checks if the signer address is already registered and thus prevents the error caused innode-lite/register.js'sStep:5 console.log(orange.bold('\n🔶 Step 5: Server Registration')).