Skip to content

Conversation

EgeCaner
Copy link
Contributor

@EgeCaner EgeCaner commented Oct 14, 2025

Adds supports for fetching events from pre-latest block for [Canonical, PreConfirmed] queries.
[PreConfirmed, PreConfirmed] will only return Preconfirmed events, not includes prelatest.

@EgeCaner EgeCaner force-pushed the feat/prelatest-in-get-events branch from 16b79fa to 77dd304 Compare October 14, 2025 12:08
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 85.10638% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.89%. Comparing base (4ab7c27) to head (750d4e1).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
blockchain/event_filter.go 84.55% 18 Missing and 3 partials ⚠️
sync/sync.go 16.66% 5 Missing ⚠️
rpc/v6/pending_data_wrapper.go 33.33% 1 Missing and 1 partial ⚠️
rpc/v7/pending_data_wrapper.go 33.33% 1 Missing and 1 partial ⚠️
rpc/v8/pending_data_wrapper.go 33.33% 1 Missing and 1 partial ⚠️
builder/builder.go 0.00% 1 Missing ⚠️
rpc/v9/pending_data_wrapper.go 50.00% 0 Missing and 1 partial ⚠️
rpc/v9/subscriptions.go 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3179      +/-   ##
==========================================
+ Coverage   73.77%   73.89%   +0.12%     
==========================================
  Files         305      305              
  Lines       35000    35106     +106     
==========================================
+ Hits        25820    25941     +121     
+ Misses       7533     7526       -7     
+ Partials     1647     1639       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@EgeCaner EgeCaner requested review from infrmtcs and rodrigo-pino and removed request for rodrigo-pino October 14, 2025 12:51
Copy link
Contributor

@rodrigo-pino rodrigo-pino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, thanks for the code, preliminary review

@EgeCaner EgeCaner force-pushed the feat/prelatest-in-get-events branch from e330992 to 750d4e1 Compare October 16, 2025 10:38
@rodrigo-pino
Copy link
Contributor

Depends on #3183

Comment on lines +73 to +82
func (e *EventFilter) SetRangeEndBlockByNumber(
filterRange EventFilterRange,
blockNumber uint64,
) error {
switch filterRange {
case EventFilterFrom:
e.fromBlock = blockNumber
} else if filterRange == EventFilterTo {
case EventFilterTo:
e.toBlock = blockNumber
} else {
default:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rodrigo-pino rodrigo-pino merged commit 1fd906f into main Oct 17, 2025
21 checks passed
@rodrigo-pino rodrigo-pino deleted the feat/prelatest-in-get-events branch October 17, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants