-
Notifications
You must be signed in to change notification settings - Fork 217
feat: prelatest in get events #3179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
16b79fa
to
77dd304
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3179 +/- ##
==========================================
+ Coverage 73.77% 73.89% +0.12%
==========================================
Files 305 305
Lines 35000 35106 +106
==========================================
+ Hits 25820 25941 +121
+ Misses 7533 7526 -7
+ Partials 1647 1639 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good, thanks for the code, preliminary review
77dd304
to
db1a410
Compare
…gracefuly handle in event filter
* []*FilteredEvents to []FilteredEvent * []*EmittedEvent to []EmittedEvent * []*SubscriptionEmittedEvent to []SubscriptionEmittedEvent
e330992
to
750d4e1
Compare
Depends on #3183 |
func (e *EventFilter) SetRangeEndBlockByNumber( | ||
filterRange EventFilterRange, | ||
blockNumber uint64, | ||
) error { | ||
switch filterRange { | ||
case EventFilterFrom: | ||
e.fromBlock = blockNumber | ||
} else if filterRange == EventFilterTo { | ||
case EventFilterTo: | ||
e.toBlock = blockNumber | ||
} else { | ||
default: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Adds supports for fetching events from
pre-latest
block for[Canonical, PreConfirmed]
queries.[PreConfirmed, PreConfirmed] will only return Preconfirmed events, not includes prelatest.