chore: use dynamic job names in depoly and test CI workflow #3161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces dynamic job names to GitHub Actions workflows by adding a configurable job_name parameter to the starknet-go-tests workflow and updating the deploy-and-test workflow to use descriptive names for different test jobs.
- Added a new
job_nameinput parameter to the starknet-go-tests workflow - Updated quote style from single to double quotes for consistency
- Implemented dynamic job naming in both workflows to distinguish between v0.8 and v0.9 test runs
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/starknet-go-tests.yml | Added job_name input parameter and applied dynamic naming to the test job |
| .github/workflows/deploy-and-test.yaml | Added name parameters for v0.8 and v0.9 test job calls |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
rodrigo-pino
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3161 +/- ##
==========================================
- Coverage 73.66% 73.44% -0.22%
==========================================
Files 305 305
Lines 34876 34964 +88
==========================================
- Hits 25691 25679 -12
- Misses 7538 7627 +89
- Partials 1647 1658 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds names to the depoly-test jobs which should make it clear which test run is what when looking into the workflow summary view.
before: https://github.com/NethermindEth/juno/actions/runs/18344356508
after: https://github.com/NethermindEth/juno/actions/runs/18341504367