Skip to content

support npm with github #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

support npm with github #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f95ec1
add a package.json
tjenkinson Aug 31, 2019
5471a9a
add to module.exports
tjenkinson Aug 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions interpreter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3944,3 +3944,7 @@ Interpreter.prototype['nativeToPseudo'] = Interpreter.prototype.nativeToPseudo;
Interpreter.prototype['pseudoToNative'] = Interpreter.prototype.pseudoToNative;
// Obsolete. Do not use.
Interpreter.prototype['createPrimitive'] = function(x) {return x;};

if (typeof exports === 'object' && typeof module === 'object') {
module.exports = Interpreter;
}
17 changes: 17 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"name": "js-interpreter",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about adding a scope, that would allow the distinction to the existing package: @neil-fraser/js-interpreter or something along those lines?

https://docs.npmjs.com/misc/scope

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 on the scoping. Is that @NeilFraser 's npm account?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that @NeilFraser 's npm account?

I rather doubt that @NeilFraser has an npm account. I might be guilty of understatement in describing him as being a bit dubious about the npm ecosystem. (I still think it would be preferable if he make his packages officially available there, though.)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If he registers an account, even if he doesn't publish there, it would be better because we could use a scoped name that no one else could take then

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be guilty of understatement in describing him as being a bit dubious about the npm ecosystem

Hopefully things have changed now in 2021 :D

"private": true,
"version": "0.0.1",
"description": "A sandboxed JavaScript interpreter in JavaScript. Execute arbitrary JavaScript code line by line in isolation and safety.",
"main": "interpreter.js",
"repository": {
"type": "git",
"url": "git+https://github.com/NeilFraser/JS-Interpreter.git"
},
"author": "Neil Fraser",
"license": "Apache-2.0",
"bugs": {
"url": "https://github.com/NeilFraser/JS-Interpreter/issues"
},
"homepage": "https://github.com/NeilFraser/JS-Interpreter#readme"
}