Refactor: mhd_pino File Name Updates
#850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/blossom-ci |
|
LGTM, will merge when passes CI |
|
/blossom-ci |
loliverhennigh
approved these changes
May 1, 2025
loliverhennigh
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhysicsNeMo Pull Request
Description
Two files in the
mhd_pinoexample need their file names updated to reflect the change frommodulustophysicsnemo, namely loss_mhd_modulus.py and loss_mhd_vec_pot_modulus.py.Note that the imports had already expected this change.
With these updates, the imports can correctly resolve and the training scripts in
mhd_pinorun without error.Checklist
Dependencies