Fix bare except clause in timers.py #1857
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace bare except: with except (ImportError, AttributeError): to improve error handling and follow Python best practices. This change maintains backward compatibility while making debugging easier by only catching expected exceptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace bare
except:withexcept (ImportError, AttributeError):in timers.py line 28.Motivation
Bare except clauses catch all exceptions including SystemExit and KeyboardInterrupt,
which can hide bugs. Using specific exception types follows Python best practices
and makes debugging easier.
Changes
except:toexcept (ImportError, AttributeError):Testing
python -c "from megatron.core import timers; print('✓ Import successful')"dist_all_gather_func: all_gather_into_tensorChecklist