Skip to content

Topology plugin node sorting performance improvement #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Topology plugin node sorting performance improvement #588

wants to merge 3 commits into from
+72 −3

Conversation

@gshaibi
Copy link
Collaborator

@gshaibi gshaibi commented Oct 21, 2025 •
edited
Loading

No description provided.

@gshaibi gshaibi changed the title shaibi/topology plugin node sorting performance improvement Topology Plugin node sorting performance improvement Oct 21, 2025
@gshaibi gshaibi changed the title Topology Plugin node sorting performance improvement Topology plugin node sorting performance improvement Oct 21, 2025
@gshaibi gshaibi marked this pull request as draft October 22, 2025 05:22
@gshaibi gshaibi force-pushed the shaibi/topology-plugin-node-sorting-performance-improvement branch from 4781cfc to 8657d81 Compare October 22, 2025 06:30
@gshaibi gshaibi marked this pull request as ready for review October 22, 2025 08:18
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology 84.52% (+0.61%) 👍
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology/common.go 100.00% (+100.00%) 6 (+6) 6 (+6) 0 🌟
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology/job_filtering.go 92.82% (-0.44%) 181 (+3) 168 (+2) 13 (+1) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology/topology_plugin.go 91.49% (+2.02%) 47 (+9) 43 (+9) 4 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology/job_filtering_test.go

@gshaibi gshaibi enabled auto-merge (squash) October 22, 2025 08:47
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology 84.52% (+0.61%) 👍
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology/common.go 100.00% (+100.00%) 6 (+6) 6 (+6) 0 🌟
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology/job_filtering.go 92.82% (-0.44%) 181 (+3) 168 (+2) 13 (+1) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology/topology_plugin.go 91.49% (+2.02%) 47 (+9) 43 (+9) 4 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology/job_filtering_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enoodle enoodle enoodle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gshaibi @enoodle