Convert Ephemeral-Storage in MaxNodePoolResources from Bytes to GB #566
+66
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 12, 2025 13:44
…g and converting memory from Bytes to GB.
…to bugfix/fix-issue400
enoodle
reviewed
Oct 13, 2025
|
|
||
| for rName, rQuant := range r.scalarResources { | ||
| messageBuilder.WriteString(fmt.Sprintf(", %s: %v", rName, rQuant)) | ||
| messageBuilder.WriteString(fmt.Sprintf(", %s: %v", rName, rQuant)) |
There was a problem hiding this comment.
This will cause the linter to file
enoodle
requested changes
Oct 28, 2025
| for rName, rQuant := range r.scalarResources { | ||
| messageBuilder.WriteString(fmt.Sprintf(", %s: %v", rName, rQuant)) | ||
| if rName == v1.ResourceEphemeralStorage || rName == v1.ResourceStorage { | ||
| rQuant = rQuant / (1000 * 1000 * 1000) // convert from milli-bytes to GB |
There was a problem hiding this comment.
Suggested change
| rQuant = rQuant / (1000 * 1000 * 1000) // convert from milli-bytes to GB | |
| rQuant = rQuant / (MemoryToGB) // convert from milli-bytes to GB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test case for ephemeral storage testing. Made changes in reading and converting memory from Bytes to GB.