Time aware fairness simulation env tests #554

itsomri · 2025-10-01T08:28:44Z

This PR adds a simulator to test time-aware-fairness logic over time.
A simulation has the following inputs:

Queues: a list of queues, with optional quota, priority and weight
Jobs: a list of jobs, with pod & gpu count
Nodes: a list of nodes with GPU counts
The number of cycles the simulation should run for

pkg/env-tests/time_aware_fairness_test.go

SiorMeir

Looks good!

Added a few suggestion

github-actions · 2025-10-16T14:30:51Z

Merging this branch will decrease overall coverage

Impacted Packages	Coverage Δ	🤖
github.com/NVIDIA/KAI-scheduler/cmd/podgroupcontroller	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/cmd/podgroupcontroller/app	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/cmd/queuecontroller/app	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests	73.86% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/binder	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/podgroupcontroller	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/queuecontroller	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/scheduler	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/operator/controller/integration_tests	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/podgroupcontroller/controllers	43.75% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/queuecontroller/controllers	86.05% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/queuecontroller/metrics	84.78% (-0.61%)	👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb	56.98% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/fake	0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/NVIDIA/KAI-scheduler/cmd/podgroupcontroller/app/app.go	0.00% (ø)	30	0	30
github.com/NVIDIA/KAI-scheduler/cmd/podgroupcontroller/app/options.go	0.00% (ø)	14 (+3)	0	14 (+3)
github.com/NVIDIA/KAI-scheduler/cmd/podgroupcontroller/main.go	0.00% (ø)	10	0	10
github.com/NVIDIA/KAI-scheduler/cmd/queuecontroller/app/app.go	0.00% (ø)	31	0	31
github.com/NVIDIA/KAI-scheduler/cmd/queuecontroller/app/options.go	0.00% (ø)	12 (+1)	0	12 (+1)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/binder/binder.go	0.00% (ø)	24 (+1)	0	24 (+1)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/podgroupcontroller/podgroupcontroller.go	0.00% (ø)	10 (+1)	0	10 (+1)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/queuecontroller/queuecontroller.go	0.00% (ø)	11 (+1)	0	11 (+1)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/scheduler/scheduler.go	0.00% (ø)	26 (+2)	0	26 (+2)
github.com/NVIDIA/KAI-scheduler/pkg/podgroupcontroller/controllers/pod_group_controller.go	0.00% (ø)	27	0	27
github.com/NVIDIA/KAI-scheduler/pkg/queuecontroller/controllers/queue_controller.go	86.05% (ø)	43	37	6
github.com/NVIDIA/KAI-scheduler/pkg/queuecontroller/metrics/metrics.go	84.78% (-0.61%)	92 (+3)	78 (+2)	14 (+1)	👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/fake/fake.go	0.00% (ø)	10 (+2)	0	10 (+2)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/fake/fake_with_history.go	0.00% (ø)	49 (+49)	0	49 (+49)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/hub.go	100.00% (ø)	27	27	0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

github.com/NVIDIA/KAI-scheduler/pkg/env-tests/time_aware_fairness_test.go
github.com/NVIDIA/KAI-scheduler/pkg/operator/controller/integration_tests/suite_test.go
github.com/NVIDIA/KAI-scheduler/pkg/queuecontroller/controllers/suite_test.go
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/hub_test.go

github-actions · 2025-10-19T07:19:52Z

Merging this branch will decrease overall coverage

Impacted Packages	Coverage Δ	🤖
github.com/NVIDIA/KAI-scheduler/cmd/podgroupcontroller	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/cmd/podgroupcontroller/app	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/cmd/queuecontroller/app	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests	72.73% (-1.14%)	👎
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/binder	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/podgroupcontroller	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/queuecontroller	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/scheduler	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/operator/controller/integration_tests	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/podgroupcontroller/controllers	43.75% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/queuecontroller/controllers	86.05% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/queuecontroller/metrics	84.78% (-0.61%)	👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb	56.98% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/fake	0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/NVIDIA/KAI-scheduler/cmd/podgroupcontroller/app/app.go	0.00% (ø)	30	0	30
github.com/NVIDIA/KAI-scheduler/cmd/podgroupcontroller/app/options.go	0.00% (ø)	14 (+3)	0	14 (+3)
github.com/NVIDIA/KAI-scheduler/cmd/podgroupcontroller/main.go	0.00% (ø)	10	0	10
github.com/NVIDIA/KAI-scheduler/cmd/queuecontroller/app/app.go	0.00% (ø)	31	0	31
github.com/NVIDIA/KAI-scheduler/cmd/queuecontroller/app/options.go	0.00% (ø)	12 (+1)	0	12 (+1)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/binder/binder.go	0.00% (ø)	24 (+1)	0	24 (+1)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/podgroupcontroller/podgroupcontroller.go	0.00% (ø)	10 (+1)	0	10 (+1)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/queuecontroller/queuecontroller.go	0.00% (ø)	11 (+1)	0	11 (+1)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/scheduler/scheduler.go	0.00% (ø)	26 (+2)	0	26 (+2)
github.com/NVIDIA/KAI-scheduler/pkg/podgroupcontroller/controllers/pod_group_controller.go	0.00% (ø)	27	0	27
github.com/NVIDIA/KAI-scheduler/pkg/queuecontroller/controllers/queue_controller.go	86.05% (ø)	43	37	6
github.com/NVIDIA/KAI-scheduler/pkg/queuecontroller/metrics/metrics.go	84.78% (-0.61%)	92 (+3)	78 (+2)	14 (+1)	👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/fake/fake.go	0.00% (ø)	10 (+2)	0	10 (+2)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/fake/fake_with_history.go	0.00% (ø)	49 (+49)	0	49 (+49)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/hub.go	100.00% (ø)	27	27	0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

github.com/NVIDIA/KAI-scheduler/pkg/env-tests/time_aware_fairness_test.go
github.com/NVIDIA/KAI-scheduler/pkg/operator/controller/integration_tests/suite_test.go
github.com/NVIDIA/KAI-scheduler/pkg/queuecontroller/controllers/suite_test.go
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/hub_test.go

github-actions · 2025-10-19T08:59:35Z

Merging this branch will decrease overall coverage

Impacted Packages	Coverage Δ	🤖
github.com/NVIDIA/KAI-scheduler/cmd/podgroupcontroller	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/cmd/podgroupcontroller/app	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/cmd/queuecontroller/app	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests	73.86% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/binder	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/podgroupcontroller	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/queuecontroller	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/scheduler	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/operator/controller/integration_tests	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/podgroupcontroller/controllers	43.75% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/queuecontroller/controllers	86.05% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/queuecontroller/metrics	84.78% (-0.61%)	👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb	56.98% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/fake	0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/NVIDIA/KAI-scheduler/cmd/podgroupcontroller/app/app.go	0.00% (ø)	30	0	30
github.com/NVIDIA/KAI-scheduler/cmd/podgroupcontroller/app/options.go	0.00% (ø)	14 (+3)	0	14 (+3)
github.com/NVIDIA/KAI-scheduler/cmd/podgroupcontroller/main.go	0.00% (ø)	10	0	10
github.com/NVIDIA/KAI-scheduler/cmd/queuecontroller/app/app.go	0.00% (ø)	31	0	31
github.com/NVIDIA/KAI-scheduler/cmd/queuecontroller/app/options.go	0.00% (ø)	12 (+1)	0	12 (+1)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/binder/binder.go	0.00% (ø)	24 (+1)	0	24 (+1)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/podgroupcontroller/podgroupcontroller.go	0.00% (ø)	10 (+1)	0	10 (+1)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/queuecontroller/queuecontroller.go	0.00% (ø)	11 (+1)	0	11 (+1)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/scheduler/scheduler.go	0.00% (ø)	26 (+2)	0	26 (+2)
github.com/NVIDIA/KAI-scheduler/pkg/podgroupcontroller/controllers/pod_group_controller.go	0.00% (ø)	27	0	27
github.com/NVIDIA/KAI-scheduler/pkg/queuecontroller/controllers/queue_controller.go	86.05% (ø)	43	37	6
github.com/NVIDIA/KAI-scheduler/pkg/queuecontroller/metrics/metrics.go	84.78% (-0.61%)	92 (+3)	78 (+2)	14 (+1)	👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/fake/fake.go	0.00% (ø)	10 (+2)	0	10 (+2)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/fake/fake_with_history.go	0.00% (ø)	49 (+49)	0	49 (+49)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/hub.go	100.00% (ø)	27	27	0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

github.com/NVIDIA/KAI-scheduler/pkg/env-tests/time_aware_fairness_test.go
github.com/NVIDIA/KAI-scheduler/pkg/operator/controller/integration_tests/suite_test.go
github.com/NVIDIA/KAI-scheduler/pkg/queuecontroller/controllers/suite_test.go
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/hub_test.go

github-actions · 2025-10-19T12:58:03Z

Merging this branch will decrease overall coverage

Impacted Packages	Coverage Δ	🤖
github.com/NVIDIA/KAI-scheduler/cmd/podgroupcontroller	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/cmd/podgroupcontroller/app	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/cmd/queuecontroller/app	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests	73.86% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/binder	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/podgroupcontroller	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/queuecontroller	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/scheduler	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/operator/controller/integration_tests	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/podgroupcontroller/controllers	43.75% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/queuecontroller/controllers	86.05% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/queuecontroller/metrics	84.78% (-0.61%)	👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb	56.98% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/fake	0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/NVIDIA/KAI-scheduler/cmd/podgroupcontroller/app/app.go	0.00% (ø)	30	0	30
github.com/NVIDIA/KAI-scheduler/cmd/podgroupcontroller/app/options.go	0.00% (ø)	14 (+3)	0	14 (+3)
github.com/NVIDIA/KAI-scheduler/cmd/podgroupcontroller/main.go	0.00% (ø)	10	0	10
github.com/NVIDIA/KAI-scheduler/cmd/queuecontroller/app/app.go	0.00% (ø)	31	0	31
github.com/NVIDIA/KAI-scheduler/cmd/queuecontroller/app/options.go	0.00% (ø)	12 (+1)	0	12 (+1)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/binder/binder.go	0.00% (ø)	24 (+1)	0	24 (+1)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/podgroupcontroller/podgroupcontroller.go	0.00% (ø)	10 (+1)	0	10 (+1)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/queuecontroller/queuecontroller.go	0.00% (ø)	11 (+1)	0	11 (+1)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/scheduler/scheduler.go	0.00% (ø)	26 (+2)	0	26 (+2)
github.com/NVIDIA/KAI-scheduler/pkg/podgroupcontroller/controllers/pod_group_controller.go	0.00% (ø)	27	0	27
github.com/NVIDIA/KAI-scheduler/pkg/queuecontroller/controllers/queue_controller.go	86.05% (ø)	43	37	6
github.com/NVIDIA/KAI-scheduler/pkg/queuecontroller/metrics/metrics.go	84.78% (-0.61%)	92 (+3)	78 (+2)	14 (+1)	👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/fake/fake.go	0.00% (ø)	10 (+2)	0	10 (+2)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/fake/fake_with_history.go	0.00% (ø)	49 (+49)	0	49 (+49)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/hub.go	100.00% (ø)	27	27	0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

github.com/NVIDIA/KAI-scheduler/pkg/env-tests/time_aware_fairness_test.go
github.com/NVIDIA/KAI-scheduler/pkg/operator/controller/integration_tests/suite_test.go
github.com/NVIDIA/KAI-scheduler/pkg/queuecontroller/controllers/suite_test.go
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/hub_test.go

github-actions · 2025-10-20T12:45:31Z

Merging this branch changes the coverage (2 decrease, 1 increase)

Impacted Packages	Coverage Δ	🤖
github.com/NVIDIA/KAI-scheduler/cmd/podgroupcontroller	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/cmd/podgroupcontroller/app	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/cmd/queuecontroller/app	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests	73.86% (+1.14%)	👍
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/binder	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/podgroupcontroller	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/queuecontroller	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/scheduler	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/operator/controller/integration_tests	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/podgroupcontroller/controllers	43.75% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/queuecontroller/controllers	83.72% (-2.33%)	👎
github.com/NVIDIA/KAI-scheduler/pkg/queuecontroller/metrics	84.78% (-0.61%)	👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb	56.98% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/fake	0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/NVIDIA/KAI-scheduler/cmd/podgroupcontroller/app/app.go	0.00% (ø)	30	0	30
github.com/NVIDIA/KAI-scheduler/cmd/podgroupcontroller/app/options.go	0.00% (ø)	14 (+3)	0	14 (+3)
github.com/NVIDIA/KAI-scheduler/cmd/podgroupcontroller/main.go	0.00% (ø)	10	0	10
github.com/NVIDIA/KAI-scheduler/cmd/queuecontroller/app/app.go	0.00% (ø)	31	0	31
github.com/NVIDIA/KAI-scheduler/cmd/queuecontroller/app/options.go	0.00% (ø)	12 (+1)	0	12 (+1)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/binder/binder.go	0.00% (ø)	24 (+1)	0	24 (+1)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/podgroupcontroller/podgroupcontroller.go	0.00% (ø)	10 (+1)	0	10 (+1)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/queuecontroller/queuecontroller.go	0.00% (ø)	11 (+1)	0	11 (+1)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/scheduler/scheduler.go	0.00% (ø)	26 (+2)	0	26 (+2)
github.com/NVIDIA/KAI-scheduler/pkg/podgroupcontroller/controllers/pod_group_controller.go	0.00% (ø)	27	0	27
github.com/NVIDIA/KAI-scheduler/pkg/queuecontroller/controllers/queue_controller.go	83.72% (-2.33%)	43	36 (-1)	7 (+1)	👎
github.com/NVIDIA/KAI-scheduler/pkg/queuecontroller/metrics/metrics.go	84.78% (-0.61%)	92 (+3)	78 (+2)	14 (+1)	👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/fake/fake.go	0.00% (ø)	10 (+2)	0	10 (+2)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/fake/fake_with_history.go	0.00% (ø)	49 (+49)	0	49 (+49)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/hub.go	100.00% (ø)	27	27	0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

github.com/NVIDIA/KAI-scheduler/pkg/env-tests/time_aware_fairness_test.go
github.com/NVIDIA/KAI-scheduler/pkg/operator/controller/integration_tests/suite_test.go
github.com/NVIDIA/KAI-scheduler/pkg/queuecontroller/controllers/suite_test.go
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/hub_test.go

pkg/env-tests/time_aware_fairness_test.go

pkg/queuecontroller/metrics/metrics.go

github-actions · 2025-10-22T11:38:17Z

Merging this branch will decrease overall coverage

Impacted Packages	Coverage Δ	🤖
github.com/NVIDIA/KAI-scheduler/cmd/podgroupcontroller	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/cmd/podgroupcontroller/app	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/cmd/queuecontroller/app	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests	68.82% (-3.91%)	👎
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/binder	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/podgroupcontroller	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/queuecontroller	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/scheduler	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/operator/controller/integration_tests	0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/podgroupcontroller/controllers	43.75% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/queuecontroller/controllers	86.05% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/queuecontroller/metrics	84.78% (-0.61%)	👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb	56.98% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/fake	0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/NVIDIA/KAI-scheduler/cmd/podgroupcontroller/app/app.go	0.00% (ø)	30	0	30
github.com/NVIDIA/KAI-scheduler/cmd/podgroupcontroller/app/options.go	0.00% (ø)	14 (+3)	0	14 (+3)
github.com/NVIDIA/KAI-scheduler/cmd/podgroupcontroller/main.go	0.00% (ø)	10	0	10
github.com/NVIDIA/KAI-scheduler/cmd/queuecontroller/app/app.go	0.00% (ø)	31	0	31
github.com/NVIDIA/KAI-scheduler/cmd/queuecontroller/app/options.go	0.00% (ø)	12 (+1)	0	12 (+1)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/binder/binder.go	0.00% (ø)	24 (+1)	0	24 (+1)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/podgroupcontroller/podgroupcontroller.go	0.00% (ø)	10 (+1)	0	10 (+1)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/queuecontroller/queuecontroller.go	0.00% (ø)	11 (+1)	0	11 (+1)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/scheduler/scheduler.go	0.00% (ø)	26 (+2)	0	26 (+2)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/utils.go	68.82% (-3.91%)	93 (+5)	64	29 (+5)	👎
github.com/NVIDIA/KAI-scheduler/pkg/podgroupcontroller/controllers/pod_group_controller.go	0.00% (ø)	27	0	27
github.com/NVIDIA/KAI-scheduler/pkg/queuecontroller/controllers/queue_controller.go	86.05% (ø)	43	37	6
github.com/NVIDIA/KAI-scheduler/pkg/queuecontroller/metrics/metrics.go	84.78% (-0.61%)	92 (+3)	78 (+2)	14 (+1)	👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/fake/fake.go	0.00% (ø)	10 (+2)	0	10 (+2)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/fake/fake_with_history.go	0.00% (ø)	49 (+49)	0	49 (+49)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/hub.go	100.00% (ø)	27	27	0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

github.com/NVIDIA/KAI-scheduler/pkg/env-tests/time_aware_fairness_test.go
github.com/NVIDIA/KAI-scheduler/pkg/operator/controller/integration_tests/suite_test.go
github.com/NVIDIA/KAI-scheduler/pkg/queuecontroller/controllers/suite_test.go
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/usagedb/hub_test.go

itsomri force-pushed the omric/time-aware-env-tests branch 4 times, most recently from 1db0bd0 to 88c3326 Compare October 9, 2025 12:38

SiorMeir reviewed Oct 12, 2025

View reviewed changes

pkg/env-tests/time_aware_fairness_test.go Outdated Show resolved Hide resolved

SiorMeir reviewed Oct 12, 2025

View reviewed changes

pkg/env-tests/time_aware_fairness_test.go Outdated Show resolved Hide resolved

SiorMeir reviewed Oct 12, 2025

View reviewed changes

pkg/env-tests/time_aware_fairness_test.go Outdated Show resolved Hide resolved

SiorMeir previously approved these changes Oct 12, 2025

View reviewed changes

itsomri dismissed SiorMeir’s stale review via 20c9e18 October 12, 2025 11:20

itsomri force-pushed the omric/time-aware-env-tests branch 5 times, most recently from c764bf5 to a0b9848 Compare October 16, 2025 11:24

itsomri force-pushed the omric/time-aware-env-tests branch from 712052e to b6672d8 Compare October 17, 2025 14:03

itsomri force-pushed the omric/time-aware-env-tests branch from edb2e0e to a950c2d Compare October 19, 2025 12:29

itsomri force-pushed the omric/time-aware-env-tests branch 3 times, most recently from 412445d to e63b579 Compare October 20, 2025 12:16

enoodle reviewed Oct 20, 2025

View reviewed changes

pkg/env-tests/time_aware_fairness_test.go Show resolved Hide resolved

pkg/env-tests/time_aware_fairness_test.go Outdated Show resolved Hide resolved

pkg/env-tests/time_aware_fairness_test.go Outdated Show resolved Hide resolved

enoodle previously approved these changes Oct 20, 2025

View reviewed changes

itsomri dismissed enoodle’s stale review via 373d185 October 20, 2025 14:52

gshaibi previously approved these changes Oct 20, 2025

View reviewed changes

pkg/queuecontroller/metrics/metrics.go Show resolved Hide resolved

itsomri added 2 commits October 22, 2025 13:45

WIP

ae18cfd

remove unused

6a8720e

itsomri added 13 commits October 22, 2025 13:45

Remove resource division change

b0ee3c3

Implemented with dataframe

ec3df27

Fixed client hub tests

923db16

Refactored simulation to a reusable function

27ab006

CR fixes

602bdd9

Single queuecontroller metric initiation

5a05c3d

Fix controller name clash

05fcc2d

Disable metrics and probes for env tests

74dc768

WIP

ec5a08a

Disable metrics in operator tests

d15dd2e

Added tag to skip tests by default

6401525

Consolidated cleanup function

c67ab08

Disable metrics for queuecontroller env tests

d1a6166

itsomri dismissed gshaibi’s stale review via d1a6166 October 22, 2025 10:45

itsomri force-pushed the omric/time-aware-env-tests branch from 373d185 to d1a6166 Compare October 22, 2025 10:45

itsomri added 2 commits October 22, 2025 13:52

Increase window size to 6

96a7267

Skip unless env var is set

0219cbb

enoodle previously approved these changes Oct 22, 2025

View reviewed changes

Fix error wrapping

fd9fdce

itsomri dismissed enoodle’s stale review via fd9fdce October 22, 2025 11:05

Naming

6bce9dd

enoodle approved these changes Oct 22, 2025

View reviewed changes

itsomri enabled auto-merge (squash) October 22, 2025 11:10

itsomri merged commit 8409531 into main Oct 22, 2025
4 checks passed

itsomri deleted the omric/time-aware-env-tests branch October 22, 2025 11:38

Time aware fairness simulation env tests #554

Time aware fairness simulation env tests #554

Uh oh!

Conversation

itsomri commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SiorMeir left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 16, 2025

Merging this branch will decrease overall coverage

Changed files (no unit tests)

Changed unit test files

Uh oh!

github-actions bot commented Oct 19, 2025

Merging this branch will decrease overall coverage

Changed files (no unit tests)

Changed unit test files

Uh oh!

github-actions bot commented Oct 19, 2025

Merging this branch will decrease overall coverage

Changed files (no unit tests)

Changed unit test files

Uh oh!

github-actions bot commented Oct 19, 2025

Merging this branch will decrease overall coverage

Changed files (no unit tests)

Changed unit test files

Uh oh!

github-actions bot commented Oct 20, 2025

Merging this branch changes the coverage (2 decrease, 1 increase)

Changed files (no unit tests)

Changed unit test files

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 22, 2025

Merging this branch will decrease overall coverage

Changed files (no unit tests)

Changed unit test files

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

itsomri commented Oct 1, 2025 •

edited

Loading