-
Couldn't load subscription status.
- Fork 68
Enable greedy scheduler by default #5406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
!test --diff |
|
Review updated until commit 3a79735 Description
Changes walkthrough 📝
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
|
!test --diff |
|
|
||
| auto constrained_ops = getAllConstrainedOps(fusion); | ||
| if (constrained_ops.empty()) { | ||
| // Only enabled for these ops for now. Notably, PadOp, which is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small adjustment. Since the scheduler is not yet capable of optimization such as vectorization, it's only enabled for ops that are not supported by any other schedulers.
| return os.str(); | ||
| }); | ||
|
|
||
| TEST_F(GreedySchedulerTest, TMP) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accidentally added
Make the greedy scheduler enabled by default. Removed
NVFUSER_ENABLE=greedy_schedulerand addedNVFUSER_DISABLE=greedy_schedulerjust in case.