-
Notifications
You must be signed in to change notification settings - Fork 66
P2PCommunication Benchmark over Cuda IPC #5102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
51a90f2
to
3fd9af2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM.
2805c45
to
88b9974
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Defer approval to @Priya2698
88b9974
to
fa71128
Compare
fbab35a
to
874eef9
Compare
!test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Can you add the SOL bandwidth expected for the results as a reference to the PR description?
Sample output, luna80g partition on dlcluster:
The test will create a P2PCommunication with the cuda ipc backend, put it inside a HostIrEvaluator, then run it. The timer measuring the latency is
std::chrono::high_resolution_clock
.