-
Couldn't load subscription status.
- Fork 68
Add slice operation to direct bindings #4878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Description
Changes walkthrough 📝
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
|
!test |
|
!build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| error_input_generator=slice_error_generator, | ||
| reference=jax.lax.slice if JAX_AVAILABLE else None, | ||
| reference_type=ReferenceType.Jax, | ||
| supports_direct_bindings=True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat~
| stride_order=[2, 1, 0], | ||
| ) | ||
| T1 = fd.ops.slice( | ||
| T0, start_indices=offset, end_indices=(2, 5, 10), strides=(1, 1, 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: felt a bit strange that we have offset but not (2, 5, 10) as a named variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
offset is used for V_start.
|
!build |
PR List