Skip to content

Conversation

@stevehuang52
Copy link
Collaborator

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Add ASR-EOU models

Collection: [asr]

Changelog

  • Add model, dataset, training/evaluation scripts, as well as utils scripts

weiqingw4ng and others added 30 commits March 10, 2025 11:39
Signed-off-by: Weiqing Wang <[email protected]>
Signed-off-by: Weiqing Wang <[email protected]>
Signed-off-by: stevehuang52 <[email protected]>
Signed-off-by: stevehuang52 <[email protected]>
Signed-off-by: stevehuang52 <[email protected]>
Signed-off-by: stevehuang52 <[email protected]>
Signed-off-by: stevehuang52 <[email protected]>
Signed-off-by: stevehuang52 <[email protected]>
Signed-off-by: stevehuang52 <[email protected]>
Signed-off-by: stevehuang52 <[email protected]>
Signed-off-by: Weiqing Wang <[email protected]>
Signed-off-by: stevehuang52 <[email protected]>
Signed-off-by: stevehuang52 <[email protected]>
Signed-off-by: stevehuang52 <[email protected]>
Signed-off-by: stevehuang52 <[email protected]>
Signed-off-by: stevehuang52 <[email protected]>
Signed-off-by: stevehuang52 <[email protected]>
Signed-off-by: stevehuang52 <[email protected]>
Signed-off-by: stevehuang52 <[email protected]>
@github-actions github-actions bot added core Changes to NeMo Core ASR common labels Sep 16, 2025
@stevehuang52 stevehuang52 self-assigned this Sep 16, 2025
self._feat_in = feat_in
# Add 1 for blank char
self._num_classes = num_classes + 1
self._num_classes = num_classes + 1 if add_blank else num_classes
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to make it as a general frame-level classifier

stevehuang52 and others added 7 commits September 16, 2025 12:15
Signed-off-by: stevehuang52 <[email protected]>
…ed with implicit (fall through) returns

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: He Huang (Steve) <[email protected]>
…ed with implicit (fall through) returns

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: He Huang (Steve) <[email protected]>
…losed

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: He Huang (Steve) <[email protected]>
Signed-off-by: stevehuang52 <[email protected]>
Signed-off-by: stevehuang52 <[email protected]>
stevehuang52 and others added 4 commits October 8, 2025 15:37
Signed-off-by: He Huang (Steve) <[email protected]>
Signed-off-by: stevehuang52 <[email protected]>
Signed-off-by: stevehuang52 <[email protected]>
raise ValueError(f"Unknown mode {self.mode}")


class ConformerMultiLayerFeatureExtractor(NeuralModule, Exportable):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove to use the one from conformer_encoder.py to avoid duplicates

# Restore checkpoint
ckpt_path = cfg.pop('init_from_ptl_ckpt')
ckpt = torch.load(ckpt_path, map_location=map_location)
ckpt = torch.load(ckpt_path, map_location=map_location, weights_only=False)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix to avoid loading error

Signed-off-by: stevehuang52 <[email protected]>
transcripts: Optional[torch.Tensor] = None,
transcript_lengths: Optional[torch.Tensor] = None,
compute_wer: bool = False,
keep_hypotheses: bool = False,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the option to maintain hypothesis for later usage, e.g., in calculating EOU metrics


# B,D,T -> B,T,D
masks = masks.transpose(1, 2)
if masks is None:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix bug when masks is None

OmegaConf.save(metadata_yaml, new_metadata_path, resolve=True)

def _read_manifest(self, manifest_path: str, config: ASRTarredDatasetConfig):
def _read_manifest(self, manifest_path: Union[str, List[str]], config: ASRTarredDatasetConfig):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the option to read from multiple files

@stevehuang52 stevehuang52 marked this pull request as ready for review October 8, 2025 20:06
@github-actions github-actions bot removed the Run CICD label Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ASR common core Changes to NeMo Core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants