fix: pass micro_batch_size in WrappedDataLoader in PreTrainingDataModule #14644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiching
changed the title
qiching
changed the title
…dule Signed-off-by: Albert Cheng <[email protected]>
Signed-off-by: Albert Cheng <[email protected]>
…ule (Signed-off-by: Albert Cheng <[email protected]> ) Bug Description In 'PreTrainingDataModule._create_dataloader(), the 'WrappedDataLoader' was constructed without passing 'batch_size', causing it to default to 1 regardless of the setting of "micro_batch_size" in the config. Fix explicitly passed to 'WrappedDataLoader' ensuring the correct batch sizeis used during training and evaluation. Testing Verified. Signed-off-by: Albert Cheng <[email protected]>
qiching
force-pushed
the
fix-batch-size-dataloader
branch
from
93f9010 to
339f225
Compare
qiching
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Description
In 'PreTrainingDataModule._create_dataloader(), the 'WrappedDataLoader' was constructed without passing 'batch_size', causing it to default to 1 regardless of the setting of "micro_batch_size" in the config.
Fix
explicitly passed to 'WrappedDataLoader' ensuring the correct batch sizeis used during training and evaluation.
Testing
Verified.