refactor!: drop reasoning trace extraction logic #1427
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al_kwargs BREAKING CHANGE: Remove reasoning_config and apply_to_reasoning_traces config options - Remove ReasoningModelConfig, ParsedTaskOutput, and related extraction logic - Replace with automatic extraction from response.additional_kwargs['reasoning_content'] - Remove 1,085 lines of test code and related infrastructure - Simplify parse_task_output() to return str directly - Update DeepSeek-R1 and Nemotron example configs Reasoning traces are now automatically extracted by LangChain and stored in additional_kwargs, eliminating the need for token-based parsing and complex configuration options.
Pouyanpi
force-pushed
the
refactor/reasoning-traces-langchain-integration
branch
from
c4d3366 to
8aee801
Compare
Pouyanpi
changed the title
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces custom reasoning trace extraction with LangChain's built-in
additional_kwargsapproach, removing ~1,500 lines of code.Breaking Changes
reasoning_config(includingstart_token,end_token,remove_reasoning_traces) removed from model configurationapply_to_reasoning_tracesremoved from output rails configurationMigration
Remove
reasoning_configsections from config files. Reasoning traces are now automatically extracted by LangChain for supported models (e.g., DeepSeek-R1).Changes
ReasoningModelConfig,ParsedTaskOutput, token extraction logicresponse.additional_kwargs['reasoning_content']