Skip to content

Conversation

JunAishima
Copy link

No description provided.

Copy link

@AbbyGi AbbyGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General HEX comments + an additional comment

prefect.yaml Outdated
description:
- name: ucal-end-of-run-workflow-docker
version: 0.1.1
tags: [ "main" ]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional tag for beamline/endstation to keep things consistent.

Suggested change
tags: [ "main" ]
tags:
- ucal
- main

 * librsvg uses this option during configuration - removing the setting
   did not result in any problems for running a Prefect workflow
 * prevent worker host from filling with old containers
 * add extra line to match other files
 * will be done with Prefect Secret in workflow code instead
 * increment version number
  * got a coroutine error when attempting to do 'prefect deploy'. adding
    this kwarg to the load function was proposed by Prefect to fix this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants