-
Notifications
You must be signed in to change notification settings - Fork 1
Prefect3 pixi upgrade #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JunAishima
wants to merge
30
commits into
NSLS2:main
Choose a base branch
from
JunAishima:prefect3-pixi-upgrade
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* already rendered the pixi environment
* mass @ git+https://github.com/usnistgov/mass.git requires gcc but is not listed as a dependency
* updated tiled-ucal-api-key block
* pull code into /repo * use slip4netns networking instead of host * use userns settings in container_create_kwargs
* remove steps from prefect.yaml deployment file
AbbyGi
reviewed
Sep 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General HEX comments + an additional comment
prefect.yaml
Outdated
description: | ||
- name: ucal-end-of-run-workflow-docker | ||
version: 0.1.1 | ||
tags: [ "main" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional tag for beamline/endstation to keep things consistent.
Suggested change
tags: [ "main" ] | |
tags: | |
- ucal | |
- main |
* librsvg uses this option during configuration - removing the setting did not result in any problems for running a Prefect workflow
* prevent worker host from filling with old containers
* add extra line to match other files
* will be done with Prefect Secret in workflow code instead * increment version number
* got a coroutine error when attempting to do 'prefect deploy'. adding this kwarg to the load function was proposed by Prefect to fix this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.