-
Notifications
You must be signed in to change notification settings - Fork 11
add: ADPhantom migration from ioc-deploy-roles #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates functionality for the Miro Phantom series of high speed cameras to be used as Area Detector, moving it from the ioc-deploy-roles repository. The migration includes all necessary configuration files, templates, and deployment infrastructure to support ADPhantom camera IOCs.
Key changes:
- Added module configuration for ADPhantom with specific version and repository reference
- Created comprehensive device role with network interface configuration and IOC startup templates
- Included validation logic for network interface setup to prevent conflicts with existing interfaces
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
roles/install_module/vars/adphantom_fdff818.yml | Module definition specifying ADPhantom version and GitHub repository |
roles/device_roles/adphantom/templates/ifcfg-interface.sh.j2 | Network interface configuration template for camera connectivity |
roles/device_roles/adphantom/templates/base.cmd.j2 | IOC startup command template with camera and plugin configuration |
roles/device_roles/adphantom/tasks/validate_local_intf.yml | Network interface validation tasks to prevent configuration conflicts |
roles/device_roles/adphantom/tasks/main.yml | Main deployment tasks for IOC setup and network configuration |
roles/device_roles/adphantom/schema.yml | Configuration schema validation for ADPhantom IOCs |
roles/device_roles/adphantom/files/postInit.cmd | Post-initialization commands for autosave and debugging |
roles/device_roles/adphantom/files/auto_settings.req | Autosave request file for persistent settings |
roles/device_roles/adphantom/example.yml | Example configuration showing required and optional parameters |
roles/device_roles/adphantom/README.md | Basic documentation for the ADPhantom role |
roles/deploy_ioc/vars/adphantom.yml | IOC deployment configuration linking to the required module |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A handful of concerns to look through.
Co-authored-by: Dr. Phil Maffettone <[email protected]>
I think we're good to merge here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove items related to local_intf_mac and local_intf_ip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more change
Migrates functionality for the Miro Phantom series of high speed cameras to be used as Area Detector