Skip to content

Conversation

Kezzsim
Copy link
Contributor

@Kezzsim Kezzsim commented Sep 29, 2025

Migrates functionality for the Miro Phantom series of high speed cameras to be used as Area Detector

@Copilot Copilot AI review requested due to automatic review settings September 29, 2025 16:36
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates functionality for the Miro Phantom series of high speed cameras to be used as Area Detector, moving it from the ioc-deploy-roles repository. The migration includes all necessary configuration files, templates, and deployment infrastructure to support ADPhantom camera IOCs.

Key changes:

  • Added module configuration for ADPhantom with specific version and repository reference
  • Created comprehensive device role with network interface configuration and IOC startup templates
  • Included validation logic for network interface setup to prevent conflicts with existing interfaces

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
roles/install_module/vars/adphantom_fdff818.yml Module definition specifying ADPhantom version and GitHub repository
roles/device_roles/adphantom/templates/ifcfg-interface.sh.j2 Network interface configuration template for camera connectivity
roles/device_roles/adphantom/templates/base.cmd.j2 IOC startup command template with camera and plugin configuration
roles/device_roles/adphantom/tasks/validate_local_intf.yml Network interface validation tasks to prevent configuration conflicts
roles/device_roles/adphantom/tasks/main.yml Main deployment tasks for IOC setup and network configuration
roles/device_roles/adphantom/schema.yml Configuration schema validation for ADPhantom IOCs
roles/device_roles/adphantom/files/postInit.cmd Post-initialization commands for autosave and debugging
roles/device_roles/adphantom/files/auto_settings.req Autosave request file for persistent settings
roles/device_roles/adphantom/example.yml Example configuration showing required and optional parameters
roles/device_roles/adphantom/README.md Basic documentation for the ADPhantom role
roles/deploy_ioc/vars/adphantom.yml IOC deployment configuration linking to the required module

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@maffettone maffettone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A handful of concerns to look through.

@Kezzsim Kezzsim requested a review from maffettone October 1, 2025 17:42
@Kezzsim
Copy link
Contributor Author

Kezzsim commented Oct 7, 2025

I think we're good to merge here

Copy link
Contributor

@thopkins32 thopkins32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove items related to local_intf_mac and local_intf_ip

Copy link
Contributor

@thopkins32 thopkins32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more change

@thopkins32 thopkins32 merged commit 345e1e5 into NSLS2:main Oct 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants