Skip to content

Conversation

@jwlodek
Copy link
Collaborator

@jwlodek jwlodek commented Aug 25, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings August 25, 2025 17:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the PowerPMAC role from ioc-deploy-roles to a new structure, providing Ansible automation for deploying PowerPMAC IOC instances with motor control capabilities.

  • Migration of PowerPMAC role templates and configuration files
  • Addition of schema validation and example configuration
  • Integration with deploy_ioc role for IOC deployment

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
roles/powerpmac/templates/*.j2 Jinja2 templates for generating EPICS substitution files and command scripts
roles/powerpmac/tasks/main.yml Ansible tasks for deploying PowerPMAC IOC configuration
roles/powerpmac/schema.yml YAML schema defining validation rules for PowerPMAC configuration
roles/powerpmac/example.yml Example configuration showing PowerPMAC setup with axes and coordinate systems
roles/powerpmac/README.md Basic documentation for the PowerPMAC role
roles/deploy_ioc/vars/powerpmac.yml IOC deployment variables specific to PowerPMAC
Comments suppressed due to low confidence (1)

roles/powerpmac/templates/cs.substitutions.j2:20

  • The substitution line is missing a closing double quote and curly brace. The line should end with '"}' instead of just '}'.
{{"{"}}"{{ ioc.environment.SYS }}", "{{"{"}}{{ axis.component }}-Ax:{{ axis.name }}{{"}"}}Mtr", "$(SSH_PORT)"}

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@thopkins32 thopkins32 mentioned this pull request Sep 18, 2025
1 task
@thopkins32 thopkins32 mentioned this pull request Sep 18, 2025
2 tasks
@jwlodek jwlodek requested a review from thopkins32 October 20, 2025 19:04
@jwlodek
Copy link
Collaborator Author

jwlodek commented Oct 20, 2025

@thopkins32 This is now tested w/ real hardware and should be good to go.

@thopkins32 thopkins32 merged commit 8358e71 into NSLS2:main Oct 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants