-
Notifications
You must be signed in to change notification settings - Fork 11
Initial pass at migrating the PowerPMAC role from ioc-deploy-roles #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the PowerPMAC role from ioc-deploy-roles to a new structure, providing Ansible automation for deploying PowerPMAC IOC instances with motor control capabilities.
- Migration of PowerPMAC role templates and configuration files
- Addition of schema validation and example configuration
- Integration with deploy_ioc role for IOC deployment
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| roles/powerpmac/templates/*.j2 | Jinja2 templates for generating EPICS substitution files and command scripts |
| roles/powerpmac/tasks/main.yml | Ansible tasks for deploying PowerPMAC IOC configuration |
| roles/powerpmac/schema.yml | YAML schema defining validation rules for PowerPMAC configuration |
| roles/powerpmac/example.yml | Example configuration showing PowerPMAC setup with axes and coordinate systems |
| roles/powerpmac/README.md | Basic documentation for the PowerPMAC role |
| roles/deploy_ioc/vars/powerpmac.yml | IOC deployment variables specific to PowerPMAC |
Comments suppressed due to low confidence (1)
roles/powerpmac/templates/cs.substitutions.j2:20
- The substitution line is missing a closing double quote and curly brace. The line should end with '"}' instead of just '}'.
{{"{"}}"{{ ioc.environment.SYS }}", "{{"{"}}{{ axis.component }}-Ax:{{ axis.name }}{{"}"}}Mtr", "$(SSH_PORT)"}
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Thomas Hopkins <[email protected]>
|
@thopkins32 This is now tested w/ real hardware and should be good to go. |
No description provided.