Add linting #6
Open
Add linting #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* flake8, black, isort
* do flake8 separately because it only reports errors, does not actually change files
* still have some variable issues to verify
* prevent conflicts with black in handling spaces around array slicing with ":" * see pre-commit/pre-commit-hooks#112 comment from April 28, 2016 by dwaynebailey for where I saw this configuration method used
* resolve the conflict between flake8 and black, which follows the anti-pattern described here https://www.flake8rules.com/rules/W503.html
* after all code moved into tasks
* looking back at the beamline profile_collection, the tomography images are to be used here
* use "ell" instead of the lowercase letter "l" to prevent possible mis-reading (as capital I, for instance)
danielballan
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in addition to adding pre-commit linting, also clean up some of my code that I had left around after moving all of the necessary functions for the task into tasks.py