Fix PortAudio streaming and interruption. #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #10 +/- ##
===============================================
- Coverage 17.82% 17.82% -0.01%
===============================================
Files 80 80
Lines 8874 8876 +2
===============================================
Hits 1582 1582
- Misses 7292 7294 +2
Continue to review full report at Codecov.
|
zeehio
force-pushed
the
fix_portaudio_streaming
branch
from
9cb308c to
16190cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite the PortAudio engine so it works closely to the audio model in mimic.
It fixes the streaming capabilities* of mimic when using PortAudio.
Ported from MycroftAI/mimic1#137
* In case you didn't know, mimic is able to play as soon as samples start being generated. A custom function can be written (example here) to get a direct pointer to the sample data. The linked example plays the wave file, but it could simply memcpy it to a buffer if desired... That function is called right after each frame is synthesized (e.g. for clustergen voices it's called here)