Skip to content

Mitch/kv search #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Mitch/kv search #314

wants to merge 3 commits into from

Conversation

mitchelljkotler
Copy link
Member

  • URLs work
  • Needed some custom SQL. I think this is fairly optimized, but too slow for use on full documents, so I restricted to requiring a project to filter by. This might be improved upon by adding an index to the JSON field, I might try that locally
  • Also, I feel like this should probably be paginated in case of large projects with many keys? Since it uses custom SQL it would need a custom paginator, and since everything else uses cursor based pagination now, it gets slightly complicated. But it should be possible if that is what we want

@allanlasser
Copy link
Member

How does this compare with #309?

@duckduckgrayduck
Copy link
Contributor

Is it on staging? We can try to compare the two on there. I was going to take the custom SQL query approach, was worried about taking in user input to do the query.

@allanlasser allanlasser linked an issue May 16, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot search for KVs or tags
3 participants