Skip to content

Add ThirdParty option #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Add ThirdParty option #17

wants to merge 10 commits into from

Conversation

sulaiman1000
Copy link

  • CurrencyCode at CashOnDeliveryAmount param can be changed.
  • Add ThirdParty option.

@sulaiman1000
Update Core.php
a215843 
CurrencyCode can be changed  at CashOnDeliveryAmount param
@sulaiman1000
Update Core.php
7dc560b 
add ThirdParty option
@sulaiman1000
Update Core.php
633fff1 
add CustomsValueAmount
@sulaiman1000
Update main.php
3f5ccca 
add ShipperState and Shipper name to config file
@sulaiman1000
Update Core.php
107c2a2 
fix ShipperState name
@Moustafa22
Copy link
Owner

Thanks for your contribution, just remove the updates in main.php to merge to main branch
and if you can update the documentation readme.md would be grate

@sulaiman1000
Copy link
Author

@fixed @Moustafa22

Moustafa22
Moustafa22 reviewed Jan 18, 2024
View reviewed changes
src/Core.php Outdated
],
'Reference1' => $details->ShipperReference, // Should be Filled
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate Entry Reference1

sulaiman1000
sulaiman1000 commented Jan 18, 2024
View reviewed changes
Copy link
Author

@sulaiman1000 sulaiman1000 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate Entry Reference1 has been removed
@Moustafa22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Moustafa22 Moustafa22 Moustafa22 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sulaiman1000 @Moustafa22