Driver for ssd1306 using ecma-419 io and typescript typings for i2c&spi Options #1252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got an ssd1306 driver from mkellner (I believe) a while back and after a couple of tweaks I got it to work. I also "ported" to typescript, which may or may not be desirable. That required some additions to the I2C/SPI typings to expose the constructor options type.
I have all this together in two commits here, which I can split up into two PRs if desired. I also don't know how to give credit to the original code. Finally, I cheekishly put the driver into
modules/drivers/displaysas there are a ton of display drivers out there. Bottom line: I'm awaiting feedback on how you'd like this to look like or "not interested" ;-)