Skip to content

Conversation

@Alessandro100
Copy link
Contributor

Summary:

closes: https://github.com/MobilityData/product-tasks/issues/160

The styling and links for the front page of the gbfs validator

Expected behavior:

The front page of the gbfs validator should look good in any resolution and in dark mode. The links should all work (except View GBFS Validator API docs as it's not made yet)

Testing tips:

Go to 'gbfs-validator' and assure there are no visual bugs (light / dark mode) (desktop / mobile)

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)
Screenshot 2025-10-22 at 13 50 15 Screenshot 2025-10-22 at 13 45 44 Screenshot 2025-10-22 at 13 45 22

@Alessandro100 Alessandro100 requested a review from emmambd October 22, 2025 18:06
@github-actions
Copy link

github-actions bot commented Oct 22, 2025

*Lighthouse ran on https://mobility-feeds-dev--pr-1411-p9u29zfz.web.app/ * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 84 🟢 100 🟢 100 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1411-p9u29zfz.web.app/feeds * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 65 🟢 91 🟢 100 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1411-p9u29zfz.web.app/feeds/gtfs/mdb-2126 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 53 🟢 95 🟢 100 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1411-p9u29zfz.web.app/feeds/gtfs_rt/mdb-2585 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 91 🟠 88 🟢 100 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1411-p9u29zfz.web.app/gbfs/gbfs-flamingo_porirua * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 100 🟢 100 🟢 100 🟢 100

@github-actions
Copy link

Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-1411-p9u29zfz.web.app

The GBFS Validator & Visualizer is an open-source tool. We
welcome contributions from the community whether through
feature improvements, testing, or documentation. Special
thanks to{' '}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's refer to Entur here: https://entur.no/

@Alessandro100 Alessandro100 force-pushed the feat/160-gbfs-validator-front-page branch from 46fc813 to 520cca2 Compare October 27, 2025 12:33
@Alessandro100 Alessandro100 requested a review from Copilot October 27, 2025 17:39
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the front-end styling and layout improvements for the GBFS Validator page, making it responsive across different screen sizes and compatible with both light and dark themes. The changes focus on visual presentation, accessibility enhancements, and improved navigation with functional links.

Key changes:

  • Added responsive layout components and styling for the validator landing page
  • Implemented functional navigation links to external resources and internal pages
  • Enhanced accessibility with proper ARIA labels and alt text for images

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
validator.styles.ts Added new styled components for responsive promotion row layouts
index.tsx Updated hero section, promotion rows with responsive design and functional links
GbfsFeedSearchInput.tsx Added navigation functionality, improved form accessibility, and responsive layout
Header.tsx Added accessibility label to language selector

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

justifyContent: 'space-between',
alignItems: 'center',
mt: 2,
flexDirection: reverse != null && reverse ? 'row-reverse' : 'row',
Copy link

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The null check reverse != null is unnecessary. Since reverse is typed as boolean | undefined, you can simplify this to reverse ? 'row-reverse' : 'row', which will correctly handle undefined, false, and true values.

Suggested change
flexDirection: reverse != null && reverse ? 'row-reverse' : 'row',
flexDirection: reverse ? 'row-reverse' : 'row',

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants