WIP: fix: parse channel version for pre-apply check #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eiichi Kitagawa <[email protected]>
ekitagawa
changed the title
|
please include a test for the fips scenario; I will look at fixing the existing tests for your scenario |
|
Just to be safe, I will actually run the test and harvest the sample input for the test class. |
| if !strings.HasPrefix(chanParts[1], config.Version) { | ||
| return fmt.Errorf("%w; MCR version does not match channel-version '%s' vs '%s'", ErrChannelDoesntMatchVersion, chanParts[1], config.Version) | ||
| configVersionParts := strings.Split(config.Version, ".") | ||
| configChannel := configVersionParts[0] + "." + configVersionParts[1] // take only the major and minor version |
There was a problem hiding this comment.
Why are you limiting to major.minor versions and omitting the patch. The entire point to the channel validation is that in order to install a repo for a pinned patch version of MCR25, you need to use the major.minor.patch path for the repo information.
E.G.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter out suffix to better compare channel version and version in config.