-
Notifications
You must be signed in to change notification settings - Fork 617
feat: Allow mocking JSON-RPC implementations #3667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
commented
Oct 8, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3667 +/- ##
=======================================
Coverage 98.29% 98.29%
=======================================
Files 417 417
Lines 11907 11924 +17
Branches 1848 1852 +4
=======================================
+ Hits 11704 11721 +17
Misses 203 203 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mrtenz
requested changes
Oct 8, 2025
Co-authored-by: Maarten Zuidhoorn <[email protected]>
Mrtenz
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow mocking full JSON-RPC method implementations by passing functions. Also introduces
mockJsonRpcOnce
, which only mocks the first call to the method. The previous method of specifying mocks is still supported.Closes #2096
Note
Adds function-based JSON-RPC mocking and a new mockJsonRpcOnce helper (with queueing), refactoring store/middleware to support per-mock implementations and one-time behavior.
mockJsonRpc
to accept function implementations inpackages/snaps-simulation/src/helpers.ts
and types inpackages/snaps-simulation/src/types.ts
.mockJsonRpcOnce
toSnap
/helpers and expose viapackages/snaps-jest/src/helpers.ts
.{ implementation, once }
byid
; removegetJsonRpcMock
, keepgetJsonRpcMocks
(packages/snaps-simulation/src/store/mocks.ts
).once
mocks (packages/snaps-simulation/src/middleware/mock.ts
).nanoid
-based IDs and allow non-serializable middleware (serializableCheck: false
).mockJsonRpcOnce
, and queued mocks in helpers tests; update middleware/store tests to new structure.Written by Cursor Bugbot for commit 5c765f1. This will update automatically on new commits. Configure here.