perf: Change request notification order #3381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3381 +/- ##
=======================================
Coverage 98.06% 98.06%
=======================================
Files 397 397
Lines 10929 10931 +2
Branches 1720 1720
=======================================
+ Hits 10718 10720 +2
Misses 211 211 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mrtenz
reviewed
May 6, 2025
| ); | ||
|
|
||
| snapController.destroy(); | ||
| await service.terminateAllSnaps(); |
There was a problem hiding this comment.
Some of the timing changed and so the Snap is already torn down when we get to the end of the test
There was a problem hiding this comment.
It was causing the test to fail due to some timing issue where we were trying to terminate a Snap that had already been terminated. Simplest solution was to remove it for now and look into it later
Mrtenz
approved these changes
May 6, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved some of the ideas from #3356 to this PR which will be a simple to merge right away. The other referenced PR needs some more work, but is eventually what we should do.
This PR let's Snaps start their outbound request before waiting for the notification to land, this should be a small perf improvement to all requests made from the Snap.