-
Notifications
You must be signed in to change notification settings - Fork 610
Add new method to dialogs snap #3173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hmalik88
wants to merge
8
commits into
main
Choose a base branch
from
hm/update-dialogs-snap
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a08c8dd
added new method to dialogs snap to show require scroll content
hmalik88 cb06ad0
apply code review
hmalik88 83ae413
Merge branch 'main' into hm/update-dialogs-snap
hmalik88 62ec423
hook up accept/reject buttons
hmalik88 3ce3251
rebuild
hmalik88 c5df060
Merge branch 'main' into hm/update-dialogs-snap
hmalik88 98d4964
apply code review
hmalik88 ef523a6
rebuild
hmalik88 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
export * from './custom'; | ||
export * from './require-scroll-content'; |
38 changes: 38 additions & 0 deletions
38
packages/examples/packages/dialogs/src/components/require-scroll-content.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
import { | ||
Box, | ||
Button, | ||
Container, | ||
Footer, | ||
Text, | ||
type SnapComponent, | ||
} from '@metamask/snaps-sdk/jsx'; | ||
|
||
/** | ||
* Long content that requires scrolling. | ||
* | ||
* @returns The long content component. | ||
*/ | ||
export const RequireScrollContent: SnapComponent = () => ( | ||
<Container> | ||
<Box> | ||
<Text>Lorem ipsum dolor sit amet.</Text> | ||
<Text>Lorem ipsum dolor sit amet.</Text> | ||
<Text>Lorem ipsum dolor sit amet.</Text> | ||
<Text>Lorem ipsum dolor sit amet.</Text> | ||
<Text>Lorem ipsum dolor sit amet.</Text> | ||
<Text>Lorem ipsum dolor sit amet.</Text> | ||
<Text>Lorem ipsum dolor sit amet.</Text> | ||
<Text>Lorem ipsum dolor sit amet.</Text> | ||
<Text>Lorem ipsum dolor sit amet.</Text> | ||
<Text>Lorem ipsum dolor sit amet.</Text> | ||
<Text>Lorem ipsum dolor sit amet.</Text> | ||
<Text>Lorem ipsum dolor sit amet.</Text> | ||
<Text>Lorem ipsum dolor sit amet.</Text> | ||
<Text>Lorem ipsum dolor sit amet.</Text> | ||
</Box> | ||
<Footer> | ||
<Button name="reject">Reject</Button> | ||
<Button name="accept">Yes</Button> | ||
</Footer> | ||
</Container> | ||
); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.