add gitinfo class #106
Merged
add gitinfo class #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-bruten-mo
requested review from
Pierre-siddall,
mo-nikosbaltas and
t00sa
and removed request for
a team,
Pierre-siddall and
mo-nikosbaltas
t00sa
reviewed
Sep 2, 2025
Comment on lines
+71
to
+76
| for line in self.run_git(["branch"]): | ||
| if "HEAD detached" in line: | ||
| result = self.detached_head_reference | ||
| break | ||
| else: | ||
| raise GitBDiffError("unable to get branch name") |
There was a problem hiding this comment.
This chunk of code isn't currently being tested. I think it should be easy to check out a detached head in the test repo?
There was a problem hiding this comment.
Done. Have also added a couple of init.py files and a relative import, so now the unit tests can be run by just pytest from the bdiff directory
Pierre-siddall
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new class to bdiff as somewhere to get other info about a branch. For now include a function testing whether the branch provided is "main-like". This is useful for some UM tests, where we want to decide whether to run over a branch diff or the full trunk.
Checklist