Validate rose meta #105
Open
Validate rose meta #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-bruten-mo
requested review from
r-sharp and
cameronbateman-mo
and removed request for
a team
james-bruten-mo
requested review from
jennyhickson
and removed request for
r-sharp
| """ | ||
|
|
||
| print("\n\n[INFO] - Validating rose-stem apps\n\n") | ||
| failed = False |
There was a problem hiding this comment.
Suggested change
| failed = False |
| if errors: | ||
| print(f"[FAIL] - {app} failed to validate") | ||
| print(f"Failure validating app {app}:\n{errors}", file=sys.stderr) | ||
| failed = True |
There was a problem hiding this comment.
Suggested change
| failed = True | |
| return False |
| else: | ||
| print(f"[PASS] - {app} validated") | ||
|
|
||
| return failed |
There was a problem hiding this comment.
Suggested change
| return failed | |
| return True |
| """ | ||
|
|
||
| print("\n\n[INFO] - Checking rose metadata sections\n\n") | ||
| failed = False |
There was a problem hiding this comment.
Suggested change
| failed = False |
| f"Failure running rose metata-check on {section}:\n{result.stderr}", | ||
| file=sys.stderr, | ||
| ) | ||
| failed = True |
There was a problem hiding this comment.
Suggested change
| failed = True | |
| return False |
| else: | ||
| print(f"[PASS] - {section} validated") | ||
|
|
||
| return failed |
There was a problem hiding this comment.
Suggested change
| return failed | |
| return True |
cameronbateman-mo
approved these changes
Aug 27, 2025
Co-authored-by: Cameron Bateman <[email protected]>
|
Thanks Cameron, I've committed the bottom suggestion which is a good shout. I've not done the other ones. The reason for storing the state in the variable is it lets us run the test for all apps before raising an error, so we find all the issues immediately rather than fixing one and running again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary
Refactor validate_rose_meta.py and move it to SimSys_Scripts. The script will now automatically find metadata sections and apps to validate (ignoring a list of exceptions) rather than only testing based on a hardcoded list. This was done previously and meant that new metadata sections were regularly not tested.
Coordinated merge
This ticket needs to be committed before:
LFRic Apps #954
LFRic Core #4666
Checklist