Skip to content

Initial code for the server-side enchanting #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Initial code for the server-side enchanting #33

wants to merge 1 commit into from

Conversation

BlusteryS
Copy link
Member

This code will not work due to the following:

  1. ServerAuthInventories is false (StartGamePacket - 298 line):
    image
  2. We do not handle ItemStackRequest, so if we enable ServerAuthInventories the enchantment table won't work (PlayerAuthInputPacket - 73 line):
    image

@BlusteryS
Copy link
Member Author

BlusteryS commented Aug 27, 2023 •
edited
Loading

If ServerAuthInventories is false, then enchantments are generated on the client side. So we have to enable ServerAuthInventories and do some processing for item stack request packets.

@lt-name lt-name added the [Type] New Feature | 新特性 New feature or request label Aug 28, 2023
@CoolLoong
Copy link

very cool!

@lt-name lt-name force-pushed the master branch 3 times, most recently from f3db443 to f1e5570 Compare February 17, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[Type] New Feature | 新特性 New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BlusteryS @CoolLoong @lt-name