Skip to content

Fix string offset access syntax #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix string offset access syntax #22

wants to merge 1 commit into from

Conversation

McCaulay
Copy link

PHP 7.4 shows the following fatal error.

PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in vendor/maxcdn/php-maxcdn/src/MaxCDN/OAuth/OAuthSignatureMethod.php on line 50

This PR changes the access syntax to square brackets.

@ridculy
Copy link

ridculy commented Oct 26, 2021

Cany cou please release this for PHP8 ?

ridculy
ridculy approved these changes Oct 26, 2021
View reviewed changes
Copy link

@ridculy ridculy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testet it Works perfect for PHP8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ridculy ridculy ridculy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@McCaulay @ridculy