Skip to content

EbmlBinary: only set the Set flag when the whole data are read #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

EbmlBinary: only set the Set flag when the whole data are read #308

wants to merge 3 commits into from

Conversation

@robUx4
Copy link
Contributor

@robUx4 robUx4 commented Feb 28, 2025 •
edited
Loading

Also use readFully() as for the other ReadData(). So it will throw on error/EOF like the other ones.

Plus some caching.

@robUx4 robUx4 added the bug label Feb 28, 2025
@robUx4
EbmlBinary: use readFully() to make sure we read the whole data
9869643 
read() may only provide partial data.
We don't need to check for error, readFully() will throw if the data are not fully read.
@robUx4 robUx4 requested a review from mbunkus May 11, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbunkus mbunkus Awaiting requested review from mbunkus

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@robUx4