Skip to content

Integrate js-lint and removing old linting elements #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2025

Conversation

CDeltakai
Copy link
Contributor

@CDeltakai CDeltakai commented Apr 17, 2025

Description

This PR integrates the new js-lint package and removes old linting elements

Issues Fixed

Tasks

  • 1. Integrate js-lint and ensure it works as expected.
  • 2. Remove old linting elements as they are no longer needed.

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

Copy link

linear bot commented Apr 17, 2025

ENG-576

@CDeltakai CDeltakai self-assigned this Apr 17, 2025
@aryanjassal
Copy link
Member

I keep updating staging with new tracer features, so this PR has a couple of merge conflicts. You should rebase before merging.

If you usually make a release after this update, then the command used in this repo needs to be a bit different. Instead of doing something like npm version patch, you need to do npm version prerelease. If you don't usually release new versions after the linter update, then you can ignore this.

@CMCDragonkai
Copy link
Member

CMCDragonkai commented May 7, 2025 via email

@aryanjassal aryanjassal force-pushed the feature-eng-576-intrgrate-js-lint branch from c8c686b to f3565e2 Compare May 8, 2025 05:46
@aryanjassal aryanjassal force-pushed the feature-eng-576-intrgrate-js-lint branch from f3565e2 to 97686e2 Compare May 8, 2025 05:47
@CDeltakai CDeltakai merged commit 29a4fbc into staging May 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

js-logger: Integrate js-lint
3 participants