-
Notifications
You must be signed in to change notification settings - Fork 111
add cell_division_direction_function for divide() #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually quite timely and really useful! I think a couple minor changes will improve on this in ways worth considering though. Looking forward to discussing further!
} | ||
else | ||
{ | ||
rand_vec = cell_division_orientation(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason not to initialize cell_division_direction_function
as cell_division_orientation
? simplifies the logic here? I know we follow this structure you have here elsewhere in the codebase, but I think setting the default and overriding is simpler and yields simpler logic here.
Thanks for the feedback! Offhand, I'm OK with both of your suggestions: init |
I'm curious to hear as well...the only other thing that comes to mind is managing the final |
Actually, that might be one argument for keeping the if-else logic on the |
we could write a setter function that sends a default cell through the function assert these condition(s) hold. Normalization regardless. in xy-plane when in 2D. |
divide()
user_projects
workflow.To test:
Sample output:
